fix: avoid reflective access to TimeZone.defaultTimeZone in Java 9+

[vlsi]

closes #986

[jorsol]

Is not better to use the preprocessor to do the version check?

[jorsol]

it should be chatAt(2) >= '6' and you forgot the quotes for '8'.

[vlsi]

Thanks, makes sense

[jorsol]

I think the Java version check must be in an utility method.

[vlsi]

Is not better to use the preprocessor to do the version check?

preprocessor is compile-time thing, while the point is to check JRE at runtime.
We have no specific jar for Java 9, so the codebase for 8 and 9 is the same.

[codecov-io]

Codecov Report

Merging #1002 into master will increase coverage by 0.15%.
The diff coverage is 20%.

@@             Coverage Diff              @@
##             master    #1002      +/-   ##
============================================
+ Coverage     65.71%   65.87%   +0.15%     
+ Complexity     3604     3579      -25     
============================================
  Files           168      167       -1     
  Lines         15491    15320     -171     
  Branches       2494     2482      -12     
============================================
- Hits          10180    10092      -88     
+ Misses         4134     4050      -84     
- Partials       1177     1178       +1

[jugimaster]

No idea if this was the latest solution, but I'm getting the same warning on Java 11:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.postgresql.jdbc.TimestampUtils

user=> (System/getProperty "java.version")
"11.0.3"

What does the committed code do with a Java version String of "11.0.3"?

I found a commit with this:

      tzField = null;
      // Avoid reflective access in Java 9+
      if (JavaVersion.getRuntimeVersion().compareTo(JavaVersion.v1_8) <= 0) {
        tzField = TimeZone.class.getDeclaredField("defaultTimeZone");
        tzField.setAccessible(true);

How does this work? Does the tzField variable not need a value on Java 9+ (or is it set elsewhere)?

[davecramer]

Good question.

[davecramer]

@jugimaster what version of the driver are you using?

[jugimaster]

org.postgresql/postgresql "9.4.1212"

(It's a Clojure project.)

[davecramer]

upgrade the driver to the latest.

[jugimaster]

Oh, alright. I just assumed it wouldn't be older than something from 2017