Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: rephrase comment on named portals #1129

Merged
merged 1 commit into from Jun 30, 2018
Merged

style: rephrase comment on named portals #1129

merged 1 commit into from Jun 30, 2018

Conversation

@bpd0018
Copy link
Contributor

@bpd0018 bpd0018 commented Feb 18, 2018

1734 - 1738 - I think this is what the original comment was trying to convey
1743 - 1744 - clarify the meaning of the "usePortal" flag

1734 - 1738 - I think this is what the original comment was trying to convey
1743 - 1744 - clarify the meaning of the "usePortal" flag
@codecov-io
Copy link

@codecov-io codecov-io commented Feb 18, 2018

Codecov Report

Merging #1129 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1129      +/-   ##
============================================
+ Coverage     67.25%   67.28%   +0.03%     
- Complexity     3673     3675       +2     
============================================
  Files           170      170              
  Lines         15640    15640              
  Branches       2531     2531              
============================================
+ Hits          10519    10524       +5     
+ Misses         3932     3928       -4     
+ Partials       1189     1188       -1
@davecramer
Copy link
Member

@davecramer davecramer commented Feb 20, 2018

@vlsi vlsi added this to the 42.2.3 milestone Jun 30, 2018
@vlsi vlsi merged commit 86c46f9 into pgjdbc:master Jun 30, 2018
2 checks passed
2 checks passed
codecov/project 67.28% (+0.03%) compared to 45c32bc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
1734 - 1738 - I think this is what the original comment was trying to convey
1743 - 1744 - clarify the meaning of the "usePortal" flag
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
1734 - 1738 - I think this is what the original comment was trying to convey
1743 - 1744 - clarify the meaning of the "usePortal" flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.