Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link to the pull request in 42.2.3 changelog #1345

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
4 participants
@itchyny
Copy link
Contributor

commented Nov 22, 2018

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

This is a document fix.

The link of Field metadata cache can be disabled via databaseMetadataCacheFields=0 PR 1052 in https://jdbc.postgresql.org/documentation/changelog.html#version_42.2.3 is wrong. I'm not sure I can edit docs/_posts/2018-07-12-42.2.3-release.md too.

New Feature Submissions:

No

  1. Does your submission pass tests?
  2. Does mvn checkstyle:check pass ?

Changes to Existing Features:

No

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
@vlsi

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

I'm not sure I can edit docs/_posts/2018-07-12-42.2.3-release.md too.

Please do that

@itchyny

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

Thank you. I fixed the both links and rebased it.

@codecov-io

This comment has been minimized.

Copy link

commented Nov 22, 2018

Codecov Report

Merging #1345 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1345      +/-   ##
============================================
- Coverage     68.58%   68.55%   -0.04%     
+ Complexity     3883     3882       -1     
============================================
  Files           178      178              
  Lines         16205    16205              
  Branches       2646     2646              
============================================
- Hits          11114    11109       -5     
- Misses         3860     3864       +4     
- Partials       1231     1232       +1

@davecramer davecramer merged commit 9f248e1 into pgjdbc:master Nov 22, 2018

1 of 2 checks passed

codecov/project 68.55% (-0.04%) compared to f3ade07
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@itchyny itchyny deleted the itchyny:fix-changelog-pr-link-1052 branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.