style: remove extra empty lines #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build pgjdbc 1.0.188 completed (commit 2a8eb65d0a by @kazachka) |
Codecov Report
@@ Coverage Diff @@
## master #1452 +/- ##
============================================
- Coverage 68.75% 68.74% -0.01%
- Complexity 3902 3903 +1
============================================
Files 179 179
Lines 16414 16414
Branches 2672 2672
============================================
- Hits 11285 11284 -1
- Misses 3882 3883 +1
Partials 1247 1247 |
jorsol
approved these changes
Mar 31, 2019
|
@kazachka It would be nice to add the property to the check.xml to force this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created because of violations found during regression testing after implementing (checkstyle)[https://github.com/checkstyle/checkstyle] ability to check multiple lines with comments and javadocs.
Issue: checkstyle/checkstyle#5981
PR: checkstyle/checkstyle#6388
Checkstyle PR changes produce new violations in pjdbc code, which are fixed in this PR.