Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove extra empty lines #1452

Merged
merged 1 commit into from Apr 1, 2019
Merged

style: remove extra empty lines #1452

merged 1 commit into from Apr 1, 2019

Conversation

@kazachka
Copy link
Contributor

@kazachka kazachka commented Mar 31, 2019

This PR is created because of violations found during regression testing after implementing (checkstyle)[https://github.com/checkstyle/checkstyle] ability to check multiple lines with comments and javadocs.
Issue: checkstyle/checkstyle#5981
PR: checkstyle/checkstyle#6388

Checkstyle PR changes produce new violations in pjdbc code, which are fixed in this PR.

@AppVeyorBot
Copy link

@AppVeyorBot AppVeyorBot commented Mar 31, 2019

@codecov-io
Copy link

@codecov-io codecov-io commented Mar 31, 2019

Codecov Report

Merging #1452 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1452      +/-   ##
============================================
- Coverage     68.75%   68.74%   -0.01%     
- Complexity     3902     3903       +1     
============================================
  Files           179      179              
  Lines         16414    16414              
  Branches       2672     2672              
============================================
- Hits          11285    11284       -1     
- Misses         3882     3883       +1     
  Partials       1247     1247

jorsol
jorsol approved these changes Mar 31, 2019
@jorsol
Copy link
Member

@jorsol jorsol commented Mar 31, 2019

@kazachka It would be nice to add the property to the check.xml to force this.
<property name="allowMultipleEmptyLines" value="false" /> in the module EmptyLineSeparator.

@davecramer davecramer merged commit 5e48c4d into pgjdbc:master Apr 1, 2019
2 of 3 checks passed
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants