-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/chore: Add unique constraint violation code support #1453
base: master
Are you sure you want to change the base?
docs/chore: Add unique constraint violation code support #1453
Conversation
✅ Build pgjdbc 1.0.190 completed (commit 5f1ca0bb6c by @nickmarx12345678) |
style check
7a170a5
to
71679e1
Compare
✅ Build pgjdbc 1.0.191 completed (commit 325d7992ef by @nickmarx12345678) |
✅ Build pgjdbc 1.0.192 completed (commit dcd78f197b by @nickmarx12345678) |
Codecov Report
@@ Coverage Diff @@
## master #1453 +/- ##
============================================
- Coverage 68.74% 68.72% -0.02%
+ Complexity 3903 3901 -2
============================================
Files 179 179
Lines 16414 16415 +1
Branches 2672 2672
============================================
- Hits 11284 11282 -2
- Misses 3883 3884 +1
- Partials 1247 1249 +2 |
Since this is pretty easy to test for it would be good to add a test case as well |
Sure thing, will add coverage.
…On Mon, Apr 1, 2019, 3:35 AM Dave Cramer ***@***.***> wrote:
Since this is pretty easy to test for it would be good to add a test case
as well
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1453 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACLisY-DX1xTsFts45GcssfxKvAnDP5Mks5vceEAgaJpZM4cUy-g>
.
|
@nickmarx12345678 I'd love to push this, but I'd also love a test case... |
Yep have been tied up at work, if you want to close, I can reopen in a
couple days once I have the coverage there. Am a bit unfamiliar with the
convention in the codebase for tests, don't want to waste your time while I
get up to speed
…On Tue, Apr 9, 2019, 11:54 AM Dave Cramer ***@***.***> wrote:
@nickmarx12345678 <https://github.com/nickmarx12345678> I'd love to push
this, but I'd also love a test case...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1453 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACLisV690QYZiWRJ8jaQdcHRi7JA6Idlks5vfOICgaJpZM4cUy-g>
.
|
That's fine, I can leave it open. I'm trying to push a release out soon so I'm doing some housekeeping. It's labeled so I'll just leave it as is. Thanks! |
Hi :) Is there any updates? |
c25d807
to
adcb194
Compare
Looks fixed in #1699 |
4c39f96
to
866c6a9
Compare
Include an additional value to represent the PostgreSQL error code for the condition
unique_violation
. This is used for client error handling code, similar to (I assume), OBJECT_IN_USEInclude enum value for UNIQUE_CONSTRAINT_VIOLATION PSQLState
Set value to "23505" per documentation located at: https://www.postgresql.org/docs/current/errcodes-appendix.html
This is a personal issue that I came across today when attempting to handle unique constraint based exceptions, I am trying to avoid hard coding error codes in the applications.
All Submissions:
[X ] Have you followed the guidelines in our Contributing document?
[X ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?