Make ConnectTimeout test accept NoRouteToHostException

[ringerc]

The ConnectTimeout test expects an exception of type SocketTimeoutException when connecting to the unroutable address 10.255.255.1. But at least on my host (Fedora 30, OpenJDK 1.8.0_212) the connection attempt actually throws java.net.NoRouteToHostException.

That is an entirely reasonable exception to throw in this case, but not the intent of the test.

I think the test is intended to time out while connecting to the unreachable address. But it relies on highly platform-dependent behaviour. In particular if there's any sort of negative caching in place the test may fast-fail:

~/.../2Q/pgjdbc (miscfix *%)$ time ping -c 1 10.255.255.1
PING 10.255.255.1 (10.255.255.1) 56(84) bytes of data.
From 61.245.136.1 icmp_seq=1 Packet filtered

--- 10.255.255.1 ping statistics ---
1 packets transmitted, 0 received, +1 errors, 100% packet loss, time 0ms


real	0m0.122s
user	0m0.003s
sys	0m0.018s

rendering the test useless for the intended purpose.

I propose to treat this as a skipped test, per the associated pull request.

(I've also included a trivial fix for a normally-unreachable NPE I hit during testing here).

[davecramer]

LGTM

[AppVeyorBot]

✅ Build pgjdbc 1.0.336 completed (commit 38fcc079c5 by @ringerc)

[AppVeyorBot]

✅ Build pgjdbc 1.0.337 completed (commit 2a32dd64ab by @ringerc)

[codecov-io]

Codecov Report

Merging #1526 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1526      +/-   ##
============================================
+ Coverage     68.84%   68.84%   +<.01%     
  Complexity     3943     3943              
============================================
  Files           179      179              
  Lines         16478    16480       +2     
  Branches       2675     2676       +1     
============================================
+ Hits          11344    11346       +2     
+ Misses         3888     3887       -1     
- Partials       1246     1247       +1

[ringerc]

Thanks Dave, much appreciated.