-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for 42.2.11 #1720
Changelog for 42.2.11 #1720
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
============================================
+ Coverage 69.34% 69.42% +0.08%
- Complexity 4208 4214 +6
============================================
Files 187 187
Lines 17312 17312
Branches 2882 2882
============================================
+ Hits 12005 12019 +14
+ Misses 4011 4003 -8
+ Partials 1296 1290 -6 |
bbb3d17
to
ddbb39c
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
CHANGELOG.md
Outdated
- Convert silent rollbacks into exception if application sends `commit` or `xa.prepare` command [PR 1729](https://github.com/pgjdbc/pgjdbc/pull/1729) | ||
|
||
### Added | ||
- Convert silent rollbacks into exception if application sends `commit` or `xa.prepare` command [PR 1729](https://github.com/pgjdbc/pgjdbc/pull/1729) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it is "feature added" and "behaviour changed" at the same time.
Feel free to remove one of them (or rephrase?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of mentioning the new property in the added section then?
I also now wonder if we should not version properties going forward ? For instance put @SInCE in the javadoc for each property ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. I've reworded the entry in added
section.
In the future, we could add @API
annotations via https://apiguardian-team.github.io/apiguardian/docs/current/api/org/apiguardian/api/package-summary.html
looks good! Thanks |
keeping changelog current