Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 42.2.11 #1720

Merged
merged 3 commits into from Mar 10, 2020
Merged

Changelog for 42.2.11 #1720

merged 3 commits into from Mar 10, 2020

Conversation

davecramer
Copy link
Member

@davecramer davecramer commented Feb 25, 2020

keeping changelog current

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 27, 2020

Codecov Report

Merging #1720 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1720      +/-   ##
============================================
+ Coverage     69.34%   69.42%   +0.08%     
- Complexity     4208     4214       +6     
============================================
  Files           187      187              
  Lines         17312    17312              
  Branches       2882     2882              
============================================
+ Hits          12005    12019      +14     
+ Misses         4011     4003       -8     
+ Partials       1296     1290       -6

@vlsi vlsi changed the title Changelog Changelog for 42.2.11 Mar 6, 2020
@vlsi vlsi force-pushed the changelog branch 5 times, most recently from bbb3d17 to ddbb39c Compare Mar 7, 2020
@vlsi
Copy link
Member

@vlsi vlsi commented Mar 7, 2020

LGTM

bokken
bokken approved these changes Mar 7, 2020
Copy link
Member

@bokken bokken left a comment

+1

CHANGELOG.md Outdated
- Convert silent rollbacks into exception if application sends `commit` or `xa.prepare` command [PR 1729](https://github.com/pgjdbc/pgjdbc/pull/1729)

### Added
- Convert silent rollbacks into exception if application sends `commit` or `xa.prepare` command [PR 1729](https://github.com/pgjdbc/pgjdbc/pull/1729)
Copy link
Member Author

@davecramer davecramer Mar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have this twice

Copy link
Member

@vlsi vlsi Mar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is "feature added" and "behaviour changed" at the same time.
Feel free to remove one of them (or rephrase?)

Copy link
Member Author

@davecramer davecramer Mar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of mentioning the new property in the added section then?
I also now wonder if we should not version properties going forward ? For instance put @SInCE in the javadoc for each property ?

Copy link
Member

@vlsi vlsi Mar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I've reworded the entry in added section.

In the future, we could add @API annotations via https://apiguardian-team.github.io/apiguardian/docs/current/api/org/apiguardian/api/package-summary.html

@davecramer
Copy link
Member Author

@davecramer davecramer commented Mar 8, 2020

looks good! Thanks

@vlsi vlsi merged commit 41d267b into pgjdbc:master Mar 10, 2020
2 checks passed
@davecramer davecramer deleted the changelog branch Mar 31, 2020
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants