Revert "fix: add support for full names of data types" #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMH license is GPL With Classpath-Exception, so it does not require to license user-written code under GPL.
Maven -> Gradle, remove jre6
This reverts commit f554118.
2 tasks
7 tasks
bremac
added a commit
to bremac/pgjdbc
that referenced
this pull request
Sep 6, 2023
Currently, pgjdbc does not support setting arrays using ANSI type names
like `double precision` or `timestamp with timezone`. For example,
`conn.createArrayOf("double precision", new Object[] {0d})`
fails with the exception "Unable to find server array type for provided
name double precision". This can be worked around by using the PostgreSQL
type name (e.g. `float8`) instead, however it seems like the driver should
be able to handle the same set of array types as PostgreSQL itself.
This isn't the first attempt to fix this issue. In 2020, pgjdbc#1719 was merged
to fix the same problem. The patch caused some introspected types to change
(pgjdbc#1744), and was reverted by pgjdbc#1745. Adding the missing types to `TYPE_ALIASES`
fixes the problem, and avoids the OID collisions that caused pgjdbc#1744.
davecramer
pushed a commit
that referenced
this pull request
Sep 7, 2023
* fix: allow setting arrays with ANSI type name
Currently, pgjdbc does not support setting arrays using ANSI type names
like `double precision` or `timestamp with timezone`. For example,
`conn.createArrayOf("double precision", new Object[] {0d})`
fails with the exception "Unable to find server array type for provided
name double precision". This can be worked around by using the PostgreSQL
type name (e.g. `float8`) instead, however it seems like the driver should
be able to handle the same set of array types as PostgreSQL itself.
This isn't the first attempt to fix this issue. In 2020, #1719 was merged
to fix the same problem. The patch caused some introspected types to change
(#1744), and was reverted by #1745. Adding the missing types to `TYPE_ALIASES`
fixes the problem, and avoids the OID collisions that caused #1744.
* Wrap testSetArraysWithAnsiTypeNames in try-finally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change broke many things in the type cache.
I'm also not sure what it was attempting to rectify ?