-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: materialized view privileges #2209
test: materialized view privileges #2209
Conversation
Add to TestUtil and also to DatabaseMetaData setup and teardown fixes pgjdbc#2060
make "matviewtest" all lowercase so it can be found in pg catalog, which lowercases all names fixes pgjdbc#2060
Remove reused code Add comments
…gjdbc into tests_for_getTablePrivileges
Statement st = con.createStatement(); | ||
try { | ||
// Drop the view | ||
dropView(con, matViewName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be dropMaterializedView(...)
.
@@ -73,7 +73,6 @@ public void setUp() throws Exception { | |||
} | |||
TestUtil.createTable(con, "metadatatest", | |||
"id int4, name text, updated timestamptz, colour text, quest text"); | |||
TestUtil.createTable(con, "precision_test", "implicit_precision numeric"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might be basing this on an out of date branch. Rebase atop master as these changes should not be removing those tests.
pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java
Outdated
Show resolved
Hide resolved
pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java
Show resolved
Hide resolved
I did a quick review of this PR. Some changes requested. I also enabled the CI to build. You should be able to run all of this locally too. |
@mgrobaker I would love to merge this but we need some changes made. Are you able to take care of this ? |
@davecramer thank you for finishing this for me - sorry I hadn't responded to the original review |
Fixes #2060