-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional tests for getTablePrivileges() for materialized views and foreign tables #2060
Comments
Could you elaborate on this a little? I am working on this as my first issue. I've gotten everything up and running, and all tests are passing. I'm now in this test class and trying to work on the issue itself. Two questions off the top of my head - but feel free to add extra color as well
|
That PR fixed a bug where the The PR I'm suggesting someone create would be two parts:
That second one is a bit more complicated as a foreign table quite a bit more plumbing to get set up (an fdw, a foreign server, etc). So I'd suggest just doing just the materialized view piece. |
Got it, thanks - this is clear now |
Add to TestUtil and also to DatabaseMetaData setup and teardown fixes pgjdbc#2060
make "matviewtest" all lowercase so it can be found in pg catalog, which lowercases all names fixes pgjdbc#2060
Opened the PR. As you suggested, it just adds I can take a pass at |
* test: add and drop a materialized view Add to TestUtil and also to DatabaseMetaData setup and teardown fixes #2060 * test: materialized view privileges make "matviewtest" all lowercase so it can be found in pg catalog, which lowercases all names fixes #2060 Co-authored-by: Dave Cramer <davecramer@gmail.com>
Placeholder issue for adding additional test cases for materialized views and foreign tables. See #2049 for details.
This should be straight forward to add would be great first time contribution as it's totally isolated in new test code.
The text was updated successfully, but these errors were encountered: