Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process improvements #253

Merged
merged 3 commits into from Feb 17, 2015

Conversation

@alexismeneses
Copy link
Contributor

@alexismeneses alexismeneses commented Feb 4, 2015

  • It is no longer necessary to run ant with ant -lib lib <target>, required libraries are automatically loaded by the build process (typically ant all is sufficient)
  • Documentation can be built without requiring prior installation of docbook stylesheet and saxon (saxon and XSLT stylesheets are retrieved from the nexus). The following command can be used to build documentation ant snapshot-version doc (fixes #226)
  • The clean target delete the files added to the lib directory
@alexismeneses alexismeneses force-pushed the alexismeneses:build-process-improvements branch from d14b890 to cb7964e Feb 4, 2015
@alexismeneses
Copy link
Contributor Author

@alexismeneses alexismeneses commented Feb 4, 2015

Documentation build process modifications has been dropped from the PR as it's now coming from pgjdbc/www

@davecramer
Copy link
Member

@davecramer davecramer commented Feb 5, 2015

I tried ant all but I get an error ?

I also need ant snapshot, release to both work

.travis.yml build command no longer use "-lib lib" parameter in ant command so as to ensure build does not require it to run
@alexismeneses
Copy link
Contributor Author

@alexismeneses alexismeneses commented Feb 5, 2015

Dave,

I've added a commit to make travis run without -lib lib parameter and there's no error (see travis command).

What do you obtain on your side?

@davecramer
Copy link
Member

@davecramer davecramer commented Feb 5, 2015

Alexis,

I ran "ant all"

/home/davec/projects/jdbc/pgjdbc/build.xml:129: Problem: failed to create
task or type antlib:org.apache.maven.artifact.ant:dependencies
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any / declarations have taken place.
No types or tasks have been defined in this namespace yet

This appears to be an antlib declaration.
Action: Check that the implementing library exists in one of:
-/usr/local/ant/lib
-/home/davec/.ant/lib
-a directory added on the command line with the -lib argument

Dave Cramer

On 5 February 2015 at 17:45, Alexis Meneses notifications@github.com
wrote:

Dave,

I've added a commit to make travis run without -lib lib parameter and
there's no error (see travis command
https://travis-ci.org/pgjdbc/pgjdbc/jobs/49670733#L121).

What do you obtain on your side?


Reply to this email directly or view it on GitHub
#253 (comment).

@alexismeneses
Copy link
Contributor Author

@alexismeneses alexismeneses commented Feb 6, 2015

Maybe related to ant version.

According to their doc, the syntax should work starting from ant 1.7+

@davecramer
Copy link
Member

@davecramer davecramer commented Feb 6, 2015

The version of ant I have is 1.8.4

Dave

Dave Cramer

On 6 February 2015 at 02:35, Alexis Meneses notifications@github.com
wrote:

Maybe related to ant version.

According to their doc, the syntax should work starting from ant 1.7+


Reply to this email directly or view it on GitHub
#253 (comment).

@davecramer
Copy link
Member

@davecramer davecramer commented Feb 6, 2015

I just looked at your travis.yml and the projects and they still use ant
-lib lib ???

Dave Cramer

On 6 February 2015 at 06:10, Dave Cramer davecramer@gmail.com wrote:

The version of ant I have is 1.8.4

Dave

Dave Cramer

On 6 February 2015 at 02:35, Alexis Meneses notifications@github.com
wrote:

Maybe related to ant version.

According to their doc, the syntax should work starting from ant 1.7+


Reply to this email directly or view it on GitHub
#253 (comment).

@alexismeneses
Copy link
Contributor Author

@alexismeneses alexismeneses commented Feb 13, 2015

Dave,

The one from the PR is here: .travis.yml and I see no remaining -lib lib.

This command that travis has used in the latest job on this PR is here (check highlighted thin grey line).

Are we talking about the same things/files/git-branch? Am I missing something?

@davecramer
Copy link
Member

@davecramer davecramer commented Feb 15, 2015

OK, this seems to work. Not sure what I was thinking..

Dave Cramer

On 13 February 2015 at 15:52, Alexis Meneses notifications@github.com
wrote:

Dave,

The one from the PR is here: .travis.yml
https://github.com/alexismeneses/pgjdbc/blob/build-process-improvements/.travis.yml
and I see no remaining -lib lib.

This command that travis has used in the latest job on this PR is here
https://travis-ci.org/pgjdbc/pgjdbc/jobs/49670733#L121 (check
highlighted thin grey line).

Are we talking about the same things/files/git-branch? Am I missing
something?


Reply to this email directly or view it on GitHub
#253 (comment).

davecramer added a commit that referenced this pull request Feb 17, 2015
chore: Build process improvements

remove the need for defining the lib directory on the ant command line
@davecramer davecramer merged commit d893250 into pgjdbc:master Feb 17, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants