-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/urlparser improve3 pr2 #2646
base: master
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | PostgreSQL Credentials | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | PostgreSQL Credentials | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/resources/pg_service/pgservicefileProps.conf | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | Generic Database Assignment | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/resources/pg_service/pgservicefileProps.conf | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret | |
- | Generic Password | 77f14ab | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@davecramer |
@MarekUniq currently my plans are 1) merge in the issue with longs #2710 will be reopened and merged. A release with this fix will be released. I would hold off rebasing until after the above happens. Thanks for your patience |
@davecramer |
@davecramer Hi! What are merge plans? |
Is there any progress on merging this? |
I'm generally in favour of this PR. It will need to be rebased. |
|
@MarekUniq , the change reads |
@vlsi - I agree that GitHub displayed this PR in a strange way. I saw it too. (was it a glitch or my mistake, I do not know) But I noticed there were 5 new commits in |
@MarekUniq , please rebase commits so they appear "on top of the master branch". The project uses linear history rather than merge commits. |
pgjdbc/src/main/java/org/postgresql/jdbcurlresolver/PgPassParser.java
Outdated
Show resolved
Hide resolved
The key question I have here is how do we test and ensure backward compatibility? |
@vlsi I think I can't change the order of commits anymore. |
What do you mean by "can't change the order of commits"? Could you please squash at your side? |
24c5eba
to
464f9b9
Compare
@vlsi Is this the result you were expecting? I did the following:
|
464f9b9
to
a611da6
Compare
adc3c6a
to
e9676f2
Compare
e9676f2
to
aa26c91
Compare
@davecramer @sehrope @vlsi |
aa26c91
to
0ce9844
Compare
0ce9844
to
9d5daeb
Compare
1. Compatibility with libpq is improved regarding URL syntax and resolving url values
1.1.
user
andpassword
are supportedComplete syntax:
jdbc:postgresql://[[user][:password]@][host1[:port1][,host2[:port2]][,...]][/database][?property1=value1[&property2=value2][&...]]
URL may include:
user
(Optional) is the user to connect. Defaults to operating system username.password
(Optional) is the password to connect. No default value.1.2. property
passfile
is supportedExample:
1.3. Code is more clear regarding Properties override rules (source and result are logged at FINE logging level)
There are multiple sources for connection properties. If same property is specified in multiple sources then highest priority source is used. Priority list is here:
1.4. References
Related to: #2260 #2278 #2398 #2393 #2395 #2424 #2569 #2641 #2644
All Submissions:
New Feature Submissions:
./gradlew autostyleCheck checkstyleAll
pass ?Changes to Existing Features: