redo PR fix_binary_transfer_floating point from brett, removed BigDecimal where possible #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokken
reviewed
Jan 10, 2023
bokken
reviewed
Jan 10, 2023
…tible with how strings are read
bokken
reviewed
Jan 10, 2023
Comment on lines
3384
to
3385
| private static final BigDecimal LONG_MAX_BD = BigDecimal.valueOf(Long.MAX_VALUE); | ||
| private static final BigDecimal LONG_MIN_BD = BigDecimal.valueOf(Long.MIN_VALUE); |
vlsi
reviewed
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recreate PR#2710 removing BigDecimal
Original PR from @bokken