Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo PR fix_binary_transfer_floating point from brett, removed BigDecimal where possible #2719

Merged
merged 8 commits into from
Jan 12, 2023
Merged

redo PR fix_binary_transfer_floating point from brett, removed BigDecimal where possible #2719

merged 8 commits into from
Jan 12, 2023

Commits on Jan 9, 2023

  1. redo pr from brett, removed BigDecimal where possible

    @davecramer
    davecramer committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    3fe5fd7 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Use double LONG_MAX instead of float. Fix binary readLong to be compa… 

    …tible with how strings are read
    @davecramer
    davecramer committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f365eb0 View commit details
    Browse the repository at this point in the history

  2. convert to BigInteger and then test

    @davecramer
    davecramer committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    c7cc046 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. remove unused static vars

    @davecramer
    davecramer committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    b753ba8 View commit details
    Browse the repository at this point in the history

  2. cast to double

    @davecramer
    davecramer committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    6375e7c View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. remove unused import and fix failing test

    @davecramer
    davecramer committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    0bd8f03 View commit details
    Browse the repository at this point in the history

  2. make tests easier to read

    @davecramer
    davecramer committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    ae2344b View commit details
    Browse the repository at this point in the history

  3. make tests easier to read testgetBigDecimal

    @davecramer
    davecramer committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    ee8b259 View commit details
    Browse the repository at this point in the history