Add box to TypeInfoCache, fixes Issue #2746 #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know if it is the only missing type? |
I'll check some more. |
|
so answering my own question box uses a semi-colon for the delimiter |
vlsi
reviewed
Feb 3, 2023
Comment on lines
48
to
50
| TypeInfo typeInfo = ((PgConnection)con).getTypeInfo(); | ||
| // Previously we put didn't cache this. now we do. Remove it for the test | ||
| typeInfo.invalidate("box[]"); |
There was a problem hiding this comment.
I incline we should create a brand new type instead of relying on invalidate.
There was a problem hiding this comment.
Yes, that would be the best way to do this. I'll spend some time on that today
There was a problem hiding this comment.
I suggest we make a one-line change that adds box, release 42.5, and add tests later
vlsi
reviewed
Feb 3, 2023
davecramer
force-pushed
the
fixregression
branch
from
97b1132
to
e03cf48
Compare
davecramer
commented
Feb 3, 2023
This was referenced Feb 3, 2023
davecramer
added a commit
to davecramer/pgjdbc
that referenced
this pull request
Feb 20, 2023
* Add box to TypeInfoCache, fixes Issue pgjdbc#2746 * use semi-colon delimiter for box type * Fix: regression in PgResultSet LONG_MIN copy paste error fixes Issue pgjdbc#2748 (pgjdbc#2749)
davecramer
added a commit
that referenced
this pull request
Feb 20, 2023
* Add box to TypeInfoCache, fixes Issue #2746 (#2747) * use semi-colon delimiter for box type * fix: fix testGetSQLTypeQueryCache by searching for xid type. We used to search for box type but it is now cached (#2810) fix: OidValueCorrectnessTest BOX_ARRAY OID, by adding BOX_ARRAY to the oidTypeName map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curious about
pgjdbc/pgjdbc/src/main/java/org/postgresql/jdbc/TypeInfoCache.java
Lines 179 to 182 in 7bfff7a
Though