-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add box to TypeInfoCache, fixes Issue #2746 #2747
Conversation
Do you know if it is the only missing type? |
I'll check some more. |
so answering my own question
box uses a semi-colon for the delimiter |
TypeInfo typeInfo = ((PgConnection)con).getTypeInfo(); | ||
// Previously we put didn't cache this. now we do. Remove it for the test | ||
typeInfo.invalidate("box[]"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I incline we should create a brand new type instead of relying on invalidate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be the best way to do this. I'll spend some time on that today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we make a one-line change that adds box, release 42.5, and add tests later
97b1132
to
e03cf48
Compare
* Add box to TypeInfoCache, fixes Issue pgjdbc#2746 * use semi-colon delimiter for box type * Fix: regression in PgResultSet LONG_MIN copy paste error fixes Issue pgjdbc#2748 (pgjdbc#2749)
* Add box to TypeInfoCache, fixes Issue #2746 (#2747) * use semi-colon delimiter for box type * fix: fix testGetSQLTypeQueryCache by searching for xid type. We used to search for box type but it is now cached (#2810) fix: OidValueCorrectnessTest BOX_ARRAY OID, by adding BOX_ARRAY to the oidTypeName map
Curious about
pgjdbc/pgjdbc/src/main/java/org/postgresql/jdbc/TypeInfoCache.java
Lines 179 to 182 in 7bfff7a
Though