fix: NPE in DatabaseMetaData.getTypeInfo when types are dropped concurrently #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrently DatabaseMetaData.getTypeInfo used several queries to load the data, thus the first of them might observe some oid, then subsequent selects might fail to see it if the type was dropped. The solution is not 100% bulletproof, however getTypeInfo always returns full info, thus it is more likely to fail in a user-visible way.
Current coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatabaseMetaData.getTypeInfo used several queries to load the data, thus the first of them
might observe some oid, then subsequent selects might fail to see it if the type was dropped.
The solution is not 100% bulletproof, however getTypeInfo always returns full info, thus it
is more likely to fail in a user-visible way.
See http://www.postgresql.org/message-id/9436a36d38164b35ba98a6a11c836068@MERCMBX49R.na.SAS.com