fix javadocs

[davecramer]

No description provided.

[vlsi]

Is the javadoc intentionally different from the base class documentation?

I think it might be better to mark the method with @Override and trim the documentation provided it adds nothing special to the ResultSetMetaData documentation.

AFAIK, pgjdbc build procedure inherits JDK documentation.

[davecramer]

AFAICT the only reason to have documentation in the implementation is for clarity when reading the implementation. javadoc should automatically inherit the interface docs. Unless of course as you mentioned there is something special about the implementation.

[davecramer]

@OverRide it is then, as there is nothing additional Dave Cramer

…

On 24 March 2017 at 15:02, Vladimir Sitnikov ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In pgjdbc/src/main/java/org/postgresql/jdbc/PgResultSetMetaData.java <#792 (comment)>: > @@ -37,25 +37,22 @@ public PgResultSetMetaData(BaseConnection connection, Field[] fields) { fieldInfoFetched = false; } - /* - * Whats the number of columns in the ResultSet? + /** + * What's the number of columns in the ResultSet? Is the javadoc intentionally different from the base class documentation? I think it might be better to mark the method with @OverRide and trim the documentation provided it adds nothing special to the ResultSetMetaData documentation. AFAIK, pgjdbc build procedure inherits JDK documentation. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#792 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYz9kp18bgPBHRJaV5289rO11q7n4Hpks5rpBM9gaJpZM4MonZf> .

[vlsi]

It looks like I'm not quite right with documentation inheritance. I need to check my build setup.

http://static.javadoc.io/org.postgresql/postgresql/42.0.0/org/postgresql/jdbc/PgResultSet.html#getByte-int- seems to miss documentation.

[davecramer]

@vlsi did you resolve this question ?

[vlsi]

1. @davecramer , please rebase
2. I need to check why javadoc inheritance is not working properly

[codecov-io]

Codecov Report

Merging #792 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #792      +/-   ##
============================================
+ Coverage     65.94%   65.95%   +<.01%     
  Complexity     3562     3562              
============================================
  Files           166      166              
  Lines         15244    15244              
  Branches       2465     2465              
============================================
+ Hits          10053    10054       +1     
+ Misses         4022     4020       -2     
- Partials       1169     1170       +1