New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fetching a REF_CURSOR using getObject #809

Merged
merged 1 commit into from Apr 9, 2017

Conversation

Projects
None yet
3 participants
@marschall
Contributor

marschall commented Apr 8, 2017

Since DatabaseMetaData#supportsRefCursors now reports true
frameworks like Hibernate now use
callableStatement.getObject(int, ResultSet.class) to fetch the
REF_CURSOR.

Only support ResultSet.class as an argument to keep the patch simple.

Closes: #794

@marschall marschall force-pushed the marschall:ref-cursor-getObject branch from c1d6aa7 to c4516d1 Apr 8, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Apr 8, 2017

Codecov Report

Merging #809 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #809      +/-   ##
============================================
+ Coverage     65.26%   65.29%   +0.03%     
- Complexity     3518     3522       +4     
============================================
  Files           166      166              
  Lines         15226    15228       +2     
  Branches       2466     2466              
============================================
+ Hits           9937     9943       +6     
+ Misses         4100     4098       -2     
+ Partials       1189     1187       -2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 170d9c2...50428a4. Read the comment docs.

feat: support fetching a REF_CURSOR using getObject
Since DatabaseMetaData#supportsRefCursors now reports true
frameworks like Hibernate now use
callableStatement.getObject(int, ResultSet.class) to fetch the
REF_CURSOR.

Only support ResultSet.class as an argument to keep the patch simple.

Closes: #794

@marschall marschall force-pushed the marschall:ref-cursor-getObject branch from c4516d1 to 50428a4 Apr 8, 2017

@vlsi vlsi added this to the 42.1.0 milestone Apr 9, 2017

@vlsi vlsi merged commit 4ab5ccb into pgjdbc:master Apr 9, 2017

2 checks passed

codecov/project 65.29% (+0.03%) compared to 170d9c2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment