style: update checkstyle + turn on some rules

[AlexElin]

1. Update checkstyle to 7.8.2
2. Add checkstyle module "RedundantModifier"
3. Uncomment checkstyle modules "ArrayTypeStyle", "ModifierOrder"

[codecov-io]

Codecov Report

Merging #847 into master will decrease coverage by <.01%.
The diff coverage is 79.13%.

@@             Coverage Diff              @@
##             master     #847      +/-   ##
============================================
- Coverage     65.25%   65.25%   -0.01%     
+ Complexity     3519     3518       -1     
============================================
  Files           166      166              
  Lines         15253    15253              
  Branches       2474     2474              
============================================
- Hits           9954     9953       -1     
  Misses         4103     4103              
- Partials       1196     1197       +1

[davecramer]

I like the idea of checkstyle but this seems like a pretty invasive change for relatively little benefit?

What is the new rule supposed to prevent/fix/help ?

[jorsol]

It's a pretty invasive change, but I think that it help to have more quality in the code, force the uniform style in general is a good practice.

[AlexElin]

@davecramer the new rule suppused to force uniform style, prevent from writing a needless code (e.g. public modifier in inerface's methods, nested enums as static and so on)

[panchenko]

Most changes seems to be array declarations, which matches the Google code style documentation 4.8.3.2 No C-style array declarations

[vlsi]

I'm inclined to +1 the change

[davecramer]

I'm fine with it as well Dave Cramer

…

On 26 June 2017 at 11:46, Vladimir Sitnikov ***@***.***> wrote: I'm inclined to +1 the change — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#847 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYz9tCb_9vVLOigw4BGZV7KxZ602xctks5sH9I5gaJpZM4ODvJ4> .