refactor: deprecate Fastpath API #903
Conversation
change some methods in the Fastpath to accept varargs.
| * | ||
| * @param fnId Function id | ||
| * @param args FastpathArguments to pass to fastpath | ||
| * @return null if no data, byte[] otherwise | ||
| * @throws SQLException if a database-access error occurs. | ||
| */ | ||
| public byte[] fastpath(int fnId, FastpathArg[] args) throws SQLException { | ||
| public byte[] fastpath(int fnId, FastpathArg... args) throws SQLException { |
There was a problem hiding this comment.
I think this was somewhat deprecated API.
There was a problem hiding this comment.
marked as deprecated
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
============================================
+ Coverage 65.85% 65.86% +<.01%
- Complexity 3546 3547 +1
============================================
Files 166 166
Lines 15229 15230 +1
Branches 2470 2470
============================================
+ Hits 10029 10031 +2
Misses 4022 4022
+ Partials 1178 1177 -1 |
mark fastpath(int, FastpathArg[]) as Deprecated
|
Just for the reference (I mean the whole
On the other hand, I've never performed a fastpath benchmark |
|
Since is obsolete from upstream (it was obsolete since 7.4), I'm inclined to mark the whole fastpath in pgjdbc as deprecated. I guess there is no need for a benchmark or for try to use varargs here. |
deprecate Fastpath API
|
I marked the Fastpath API as deprecated and reverted using varargs |
revert adding varargs to Fastpath
AlexElin
changed the title
|
+1 |
|
@vlsi can we get this PR merged? |
change some methods in the Fastpath to accept varargs.