Fix form response file saving. Closes #7 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoolCat467
changed the title
Removed instances of unbound `AnyStr` types and ignored override from quart app also having auto restart flag
|
Thanks, I merged this manually as I've made some other updates beforehand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand it, Quart has this
Requestclass that represents requests to the server. Inside this class, there is a class attributeform_data_parser_class. Currently it's left asFormDataParser, and that doesn't work becauseFormDataParserusesFileStorage, andFileStorageuses aiofiles, which is not compatible with Trio, so it all breaks.This pull request adds new subclasses of the
FormDataParserandFileStorageclasses, namedTrioFormDataParserandTrioFileStoragerespectively, and the newTrioFileStorageclass reimplements the save and load methods to use Trio's built in asynchronous file IO instead of using aiofiles.Closes #7