Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LinearGaussianCPD member variables [fixes #961] #1330

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Fix LinearGaussianCPD member variables [fixes #961] #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pgmpy/factors/continuous/LinearGaussianCPD.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ def __init__(
self.evidence = evidence
self.sigma_yx = None

variables = [variable] + evidence
self.variables = [variable] + evidence
super(LinearGaussianCPD, self).__init__(
variables, pdf="gaussian", mean=self.mean, covariance=self.variance
self.variables, pdf="gaussian", mean=self.mean, covariance=self.variance
)

def sum_of_product(self, xi, xj):
Expand Down
12 changes: 11 additions & 1 deletion pgmpy/tests/test_models/test_LinearGaussianBayesianNetwork.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,23 @@


class TestLGBNMethods(unittest.TestCase):
@unittest.skip("TODO")
def setUp(self):
self.model = LinearGaussianBayesianNetwork([("x1", "x2"), ("x2", "x3")])
self.cpd1 = LinearGaussianCPD("x1", [1], 4)
self.cpd2 = LinearGaussianCPD("x2", [-5, 0.5], 4, ["x1"])
self.cpd3 = LinearGaussianCPD("x3", [4, -1], 3, ["x2"])

def test_cpds_simple(self):
self.assertEqual("x1", self.cpd1.variable)
self.assertEqual(4, self.cpd1.variance)
self.assertEqual([1], self.cpd1.mean)

self.model.add_cpds(self.cpd1)
cpd = self.model.get_cpds("x1")
self.assertEqual(cpd.variable, self.cpd1.variable)
self.assertEqual(cpd.variance, self.cpd1.variance)
self.assertEqual(cpd.mean, self.cpd1.mean)

@unittest.skip("TODO")
def test_add_cpds(self):
self.model.add_cpds(self.cpd1)
Expand Down