Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LinearGaussianCPD member variables [fixes #961] #1330

Merged

Conversation

theUltraMarine19
Copy link
Contributor

@theUltraMarine19 theUltraMarine19 commented Sep 30, 2020

This was causing a compilation error when declaring LinearGaussianCPDs and adding it to a LinearGaussianBayesianNetwork model

Your checklist for this pull request

Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev.
  • Check the commit's or even all commits' message styles matches our requested structure.

Issue number(s) that this pull request fixes

List of changes to the codebase in this pull request

  • Replaced variables with self.variables in init method of LinearGaussianCPD.py
  • Added a simple test test_cpds_simple which checks whether LinearGaussianCPDs have been initialized correctly and adds it to a LinearGaussianBayesianNetwork model to check whether it works.

@theUltraMarine19
Copy link
Contributor Author

This is a PR which is a replica of #962

This was causing a compilation error when declaring LinearGaussianCPDs and adding it to a LinearGaussianBayesianNetwork model
@ankurankan
Copy link
Member

@theUltraMarine19 Thanks for the PR.

@ankurankan ankurankan merged commit 838a511 into pgmpy:dev Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable naming inconsistency?
2 participants