bugfix: missing break statement after SMB feature integration prevent…

…ed XRE connection due to fields validation
pgp · Mar 3, 2019 · 86701f3 · 86701f3
1 parent 501ea95
commit 86701f3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -7,7 +7,7 @@ android {
         minSdkVersion 19
         targetSdkVersion 28
         multiDexEnabled true
-        versionCode 102190302
+        versionCode 102190303
         versionName "1.0.2-alpha"
         externalNativeBuild {
             cmake {

diff --git a/app/src/main/java/it/pgp/xfiles/dialogs/GenericChangeDirectoryDialog.java b/app/src/main/java/it/pgp/xfiles/dialogs/GenericChangeDirectoryDialog.java
@@ -151,6 +151,7 @@ and launches error dialogs (host key not found/not valid and auth error -> provi
 //                        Integer.valueOf(xreServerPort.getText().toString()),
                             xreRemotePath.getText().toString()
                     );
+                    break;
                 case 4: // SMB
                     if (!basicNonEmptyValidation(smbUser,smbDomain,smbHost,smbPort,smbPassword)) return; // password cannot be empty (no pubkey authentication for SMB)
                     path = new SmbRemotePathContent(

diff --git a/app/src/main/java/it/pgp/xfiles/utils/FavoritesList.java b/app/src/main/java/it/pgp/xfiles/utils/FavoritesList.java
@@ -5,7 +5,7 @@
 import java.util.TreeSet;
 
 /**
- * TODO will replace {@link it.pgp.xfiles.sftpclient.AuthDataWithFavorites} and {@link it.pgp.xfiles.smbclient.SmbAuthDataWithFavorites}
+ * replaces {@link it.pgp.xfiles.sftpclient.AuthDataWithFavorites} and {@link it.pgp.xfiles.smbclient.SmbAuthDataWithFavorites}
  */
 
 public class FavoritesList<T> {