Remove unused class and move detached sig initialization in own method

pgpainless · Aug 22, 2021 · 72cc60a · 72cc60a
1 parent da86ebb
commit 72cc60a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/...ss-core/src/main/java/org/pgpainless/decryption_verification/DecryptionStreamFactory.java b/...ss-core/src/main/java/org/pgpainless/decryption_verification/DecryptionStreamFactory.java
@@ -24,6 +24,7 @@
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import javax.annotation.Nonnull;
@@ -89,8 +90,11 @@ public final class DecryptionStreamFactory {
 
     public DecryptionStreamFactory(ConsumerOptions options) {
         this.options = options;
+        initializeDetachedSignatures(options.getDetachedSignatures());
+    }
 
-        for (PGPSignature signature : options.getDetachedSignatures()) {
+    private void initializeDetachedSignatures(Set<PGPSignature> signatures) {
+        for (PGPSignature signature : signatures) {
             long issuerKeyId = SignatureUtils.determineIssuerKeyId(signature);
             PGPPublicKeyRing signingKeyRing = findSignatureVerificationKeyRing(issuerKeyId);
             if (signingKeyRing == null) {

diff --git a/pgpainless-core/src/main/java/org/pgpainless/decryption_verification/OpenPgpMetadata.java b/pgpainless-core/src/main/java/org/pgpainless/decryption_verification/OpenPgpMetadata.java
@@ -146,16 +146,6 @@ public boolean containsVerifiedSignatureFrom(OpenPgpV4Fingerprint fingerprint) {
         return false;
     }
 
-    public static class Signature {
-        protected final PGPSignature signature;
-        protected final OpenPgpV4Fingerprint fingerprint;
-
-        public Signature(PGPSignature signature, OpenPgpV4Fingerprint fingerprint) {
-            this.signature = signature;
-            this.fingerprint = fingerprint;
-        }
-    }
-
     /**
      * Return the name of the encrypted / signed file.
      *