Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnit test failures for some architectures in Debians CI #309

Closed
vanitasvitae opened this issue Aug 29, 2022 · 3 comments
Closed

JUnit test failures for some architectures in Debians CI #309

vanitasvitae opened this issue Aug 29, 2022 · 3 comments
Labels
bug Something isn't working packaging Issues related to distributions of PGPainless in external repositories

Comments

@vanitasvitae
Copy link
Member

There are some strange test failures in Debians CI run on different architectures:

  • RiscV64:
    • InlineSIgnVerifyRoundtripTest:testInlineSignAndVerifyWithBinarySignatures()
    • InlineDetachTest:detachCleartextSignedMessage()
  • armel:
    • GenerateKeyWithAdditionalUserIdTest:test()

Not sure what to make out of this. The armel fail could only be caused by a very slow machine, where generation of the key takes longer than a minute. Maybe its worthwhile increasing the expiration time?

The other failures are more complex, as they are related to signature verification.

Perhaps those tests are just a bit flaky and restarting them fixes the issue? In any case, we should investigate and mitigate any reliability issues.

@vanitasvitae vanitasvitae added bug Something isn't working packaging Issues related to distributions of PGPainless in external repositories labels Aug 29, 2022
@vanitasvitae
Copy link
Member Author

As pointed out by @jcharaoui, those arches are a bit flaky, so nothing to be too worried about.

@vanitasvitae
Copy link
Member Author

I created #311 which allows to set custom reference times when creating signatures on keys. That way we are more flexible when setting up tests which check signature interpretation based on reference times.

While doing this I also increased the size of time frames by a factor of 3600 (from seconds to hours), so slow machines/architectures should now have plenty of time to execute without the risk of running out of the tests nominal time frames.

@vanitasvitae
Copy link
Member Author

This should now be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packaging Issues related to distributions of PGPainless in external repositories
Projects
None yet
Development

No branches or pull requests

1 participant