Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

msgpack.cc(181): error C2466 #46

Closed
danieler1981 opened this issue Jun 11, 2013 · 11 comments
Closed

msgpack.cc(181): error C2466 #46

danieler1981 opened this issue Jun 11, 2013 · 11 comments

Comments

@danieler1981
Copy link

Hi at all,

my configuration is:

  • Windows 7 64BIT
  • Node.JS 0.10.10
  • Python 2.7

When i try to lauch "nmp install msgpack" i get this error:

libmsgpack.vcxproj .> c:\program Files\nodejs\node_modules\msgpack\build\Release\libmsgpack.lib
msgpack.cc
..\src\msgpack.cc(181): error C2466

Can anyone help me to resolve?

Daniele

@bogushevich
Copy link

I have same problem. Wrong string was add here 247366a#L1R181 in version 0.1.7. So I install version 0.1.6
npm install msgpack@0.1.6

@godsflaw
Copy link
Collaborator

Anyone with windows want to take a stab at fixing forward?

@godsflaw
Copy link
Collaborator

Can someone try to compile the master branch on Windows for me:
7a0da2f

@bogushevich
Copy link

Win XP, VC++ 2010
Now we have a problem with function trunc():
..\src\msgpack.cc(106): error C3861: trunc: identifier not found
Header file math.h does not include trunc() in VC++. Details
Description of trunc() in VC++

@godsflaw
Copy link
Collaborator

Try master now. I just want to see if I can solve this without having to make a windows code flow. It may not work:

2a423ed

@bogushevich
Copy link

Same error: ..\src\msgpack.cc(106): error C3861: trunc: identifier not found
I add myTrunc() function to source as saing here and successfully compile module. So trunc() function is the only trouble.

@godsflaw
Copy link
Collaborator

bogushevich, try now, matthiasg rolled up a trunc() function that should work.

@bogushevich
Copy link

Win XP, VC++ 2010
Compile is successful. Thank you.

@matthiasg
Copy link
Contributor

@godsflaw can you publish a new version to npm too ?

@godsflaw
Copy link
Collaborator

@matthiasg I made a bunch of changes under the hood and was hoping to hold out for a major version bump. I will see if I can wrap things up enough to minor bump today. If I minor bump, know that msgpack.pack() is allocating memory differently, and that it has not been production tested.

@godsflaw
Copy link
Collaborator

@matthiasg Version bumped to 0.1.9 and you've been added to the contributors section. Cheers.

diunko pushed a commit to diunko/node-msgpack that referenced this issue Jul 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants