Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility for paths in the tests module #11

Closed
legaultmarc opened this issue Mar 14, 2015 · 1 comment
Closed

Windows compatibility for paths in the tests module #11

legaultmarc opened this issue Mar 14, 2015 · 1 comment
Labels
Milestone

Comments

@legaultmarc
Copy link
Member

I think we will run into path compatibility problem when using:

        data_filename = resource_filename(
            __name__,
            "data/regression_sim.txt.bz2",
        )

in the tests module. We should rewrite those bits to:

        data_filename = resource_filename(
            __name__,
            os.path.join("data", "regression_sim.txt.bz2"),
        )

I am not sure if we were going for Windows compatibility in the first place...

@legaultmarc legaultmarc changed the title Win compatibility for paths in the tests module Windows compatibility for paths in the tests module Mar 14, 2015
@lemieuxl
Copy link
Member

The main pipeline does not support Windows, since this operating system is not supported by SHAPEIT (phasing tool).

Nevertheless, we might fix this for a future release in case SHAPEIT releases a Windows version. Also, it might be interesting to support Windows for the companion tools (e.g. imputed-stats).

@lemieuxl lemieuxl added this to the 1.3.4 milestone Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants