Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft parser for mykrobe #69

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Add draft parser for mykrobe #69

merged 6 commits into from
Jan 5, 2022

Conversation

pvanheus
Copy link
Contributor

This adds a parser for results from mykrobe. This parser is still incomplete:

  1. nucleotide_change cannot be computed from the mykrobe results
  2. drug_class does not use ARO terms
  3. computation of frequency and depth of coverage needs to be checked with mykrobe tool authors

@iqbal-lab
Copy link

Comments from me (one of the mykrobe folk)

  1. Nucleotide change indeed cannot be inferred from the mykrobe results, though in future we could look into making that visible.
  2. what are ARO terms?
  3. The json output contains a number of tags: percent_coverage refers to proportion of the probe that has coverage - there is a probe for an allele. ideally this should be 100. median_depth is the depth of coverage on the allele.

does this help?

@fmaguire
Copy link
Member

  1. Would making an issue on the mykrobe repo be useful as a possible future extension?
  2. ARO is the antibiotic resistance ontology that CARD and a few other resources are built on top of (or map back to). A nice helper for standardisation across the myriad of AMR databases and tools!
  3. Thanks, that's really useful!

@cimendes cimendes merged commit 849b98e into pha4ge:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants