Skip to content

Commit

Permalink
Adding return type.
Browse files Browse the repository at this point in the history 
Signed-off-by: Matt <gopezm@myumanitoba.ca>
  • Loading branch information
@mgopez
mgopez committed Nov 8, 2017
1 parent acaf53b commit d2adee9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bio_hansel/quality_check/quality_check_functions.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
'''


def does_subtype_result_exist(st):
def does_subtype_result_exist(st) -> bool:
if st.n_tiles_matching_all_expected is not None and len(st.n_tiles_matching_all_expected) > 0:

This comment has been minimized.

Sign in to view

Copy link
@peterk87

peterk87 Nov 8, 2017

Contributor

Slightly simpler code:

return st.subtype is not None and len(st.subtype) > 0

The subtype result does not exist in st.n_tiles_matching_all_expected so not sure why it's tested.

This comment has been minimized.

Sign in to view

Copy link
@mgopez

mgopez Nov 8, 2017

Author Member

Oh that makes sense, originally I was using st.n_tiles_matching_all_expected to verify that the quality check methods had matching tiles to compare to. I see now that if subtype is none, then matching tiles is none.
return True
else:
Expand Down

0 comments on commit d2adee9

Please sign in to comment.