Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change field names to more intuitive ones #6

Closed
peterk87 opened this issue Sep 20, 2017 · 2 comments
Closed

Change field names to more intuitive ones #6

peterk87 opened this issue Sep 20, 2017 · 2 comments

Comments

@peterk87
Copy link
Contributor

e.g n_tiles_matching_positive_total to total_n_positive_tiles_expected

@mgopez
Copy link
Member

mgopez commented Sep 27, 2017

Do you want me to do this with all fields containing *total?

@peterk87
Copy link
Contributor Author

Yeah, I think so. We may need more guidance on what should be renamed to what, but I think it's okay to proceed with renaming whatever matches that pattern.

See Subtype class:
https://github.com/phac-nml/bio_hansel/blob/master/bio_hansel/subtype.py#L18

and SUBTYPE_SUMMARY_COLS global variable:
https://github.com/phac-nml/bio_hansel/blob/master/bio_hansel/subtyper.py#L20

SUBTYPE_SUMMARY_COLS is used to order the fields/columns in the DataFrame after Subtype instances are exported to dicts and merged into a DataFrame.

If you're using PyCharm, you can probably Shift+F6 to rename the fields/properties/variables.

kbessonov1984 pushed a commit that referenced this issue Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants