Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #98 QC check for mixed subtypes #100

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Conversation

peterk87
Copy link
Contributor

…ive kmers being present at the same position

added unit tests
@peterk87
Copy link
Contributor Author

Hi @glabbe

With the changes in this pull request I am able to get the proper QC messages using the schema you linked to in #98


For ERR163996, I now get a QC FAIL with the message:

FAIL: Mixed subtype; the positive and negative kmers were found for the same target site 62657 for subtype "4.1.2".

Command-line:

$ hansel -s tb_speciation_scheme_v1.0.5.fasta -p ERR163996_* -O output.tsv --min-kmer-freq 8

For ERR182041, I now get a QC FAIL with the message:

FAIL: Mixed subtype; the positive and negative kmers were found for the same target site 4260268 for subtype ""4.6.1.1"".

Command-line

$ hansel -v -s tb_speciation_scheme_v1.0.5.fasta -p ERR182041_*.fastq.gz --min-kmer-freq 8 --force

I'll continue testing the other genomes next week!

@glabbe
Copy link
Collaborator

glabbe commented Jun 22, 2019

Great! Thanks a lot @peterk87

@peterk87 peterk87 requested a review from DarianHole June 24, 2019 13:17
Copy link
Member

@DarianHole DarianHole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes the QC issue!

All of the datasets tested are consistent with what they were before and the ones that should fail QC due to the new QC check do so.

@DarianHole DarianHole merged commit 6a9574a into development Jun 24, 2019
@peterk87 peterk87 deleted the fix/98-mixed-subtype branch July 19, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QC module not failing samples where positive and negative kmers are detected for the same genome position
3 participants