Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata NA value issue #120

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Fix metadata NA value issue #120

merged 1 commit into from
Oct 2, 2019

Conversation

peterk87
Copy link
Contributor

This PR fixes issue #112 (also adds test for metadata merging of "#N/A" subtype value)

Metadata NA value can be any of the following values and will be automatically converted by Pandas into a Pandas NaN value:

‘’, ‘#N/A’, ‘#N/A N/A’, ‘#NA’, ‘-1.#IND’, ‘-1.#QNAN’, ‘-NaN’, ‘-nan’, ‘1.#IND’, ‘1.#QNAN’, ‘N/A’, ‘NA’, ‘NULL’, ‘NaN’, ‘n/a’, ‘nan’, ‘null’.

See pandas.read_table na_values argument

Add test for metadata merging of "#N/A" subtype value
Copy link
Member

@DarianHole DarianHole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works properly in the cases I tested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants