Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #39 - zcat < file #40

Merged
merged 3 commits into from
Jun 1, 2018
Merged

Fix issue #39 - zcat < file #40

merged 3 commits into from
Jun 1, 2018

Conversation

peterk87
Copy link
Contributor

@peterk87 peterk87 commented May 11, 2018

See issue #39

To test:

# install bio_hansel
pip install git+https://github.com/phac-nml/bio_hansel.git@fix-39-zcat-mac-osx
# get test data
wget ftp://ftp.sra.ebi.ac.uk/vol1/fastq/SRR120/002/SRR1203042/SRR1203042_1.fastq.gz
# run bio_hansel on test data
hansel SRR1203042_1.fastq.gz

should produce output similar to:

sample  scheme  scheme_version  subtype all_subtypes    tiles_matching_subtype  are_subtypes_consistent inconsistent_subtypes   n_tiles_matching_all    n_tiles_matching_all_expected      n_tiles_matching_positive       n_tiles_matching_positive_expected      n_tiles_matching_subtype        n_tiles_matching_subtype_expected  file_path       avg_tile_coverage       qc_status       qc_message
SRR1203042      heidelberg      0.5.0   2.2.1.1.2       1; 2.2.1.1.2    2592097-2.2.1.1.2       False   ['1', '2.2.1.1.2']      149     202     3       18['SRR1203042_1.fastq.gz']        14.169934640522875      FAIL    "FAIL: Missing Tiles Error 1: 27.23% missing tiles; more than 5.00% missing tiles threshold. Low coverage depth (14.4 < 20.0 expected); you may need more WGS data. | FAIL: Mixed Sample Error 2: Mixed subtypes found: ""1; 2.2.1.1.2""."

specifically the subtype equal to 2.2.1.1.2 which indicates that the fastq.gz parsing is working correctly under OSX.

This fix works on Mac OSX 10.13.5 Beta and 10.12.6

OSX machines on TravisCI are usually very busy and they don't come with Python installed unfortunately...
@peterk87 peterk87 merged commit 3e057d0 into master Jun 1, 2018
peterk87 added a commit that referenced this pull request Jul 10, 2018
@peterk87 peterk87 mentioned this pull request Jul 31, 2018
@peterk87 peterk87 deleted the fix-39-zcat-mac-osx branch September 28, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant