Fixed spaces in name #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterk87
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
Hey Aaron, I think this is a reasonable fix. I've encountered the same issue with makeblastdb, and unfortunately, no amount of "quoting", '"double quoting"' or anything helped so replacing those characters is the way to go.
Once this PR passes CI, I think it'll be ready to merge.
|
Awesome, thanks Peter. |
Kurt-Hanel
pushed a commit
to Kurt-Hanel/galaxy_tools
that referenced
this pull request
Apr 15, 2019
Fixed spaces in name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where there were spaces (or other characters) in the Galaxy tool dataset name, see phac-nml/staramr#18. In this case, the dataset name was Shovill on data 11 and data 10: Contigs.fasta, but this caused issues when running staramar (in
makeblastdb).My solution for Galaxy is to swap out spaces and () characters with an underscore _.
I did not increment the Galaxy tool version number since this is just a small bugfix (when submitting to the Galaxy toolshed, this version will now labelled version
0.2.0, though the older version of the tool will still be kept around if needed).