Permalink
Browse files

Refuse writing to undeclared properties in workflows

Summary: I don't know how to not be strict here plus we (Arcanist developers) don't have access to user's error log.

Test Plan:
Undeclared `ArcanistDiffWorkflow::$console`, then:

  $ arc diff

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3607
  • Loading branch information...
1 parent 2871d00 commit 219dbe237447e91275a5aff8e3a7dd2c68c04bbe vrana committed Oct 3, 2012
Showing with 2 additions and 1 deletion.
  1. +1 −0 src/__phutil_library_map__.php
  2. +1 −1 src/workflow/ArcanistBaseWorkflow.php
@@ -158,6 +158,7 @@
'ArcanistApacheLicenseLinterTestCase' => 'ArcanistArcanistLinterTestCase',
'ArcanistArcanistLinterTestCase' => 'ArcanistLinterTestCase',
'ArcanistBaseCommitParserTestCase' => 'ArcanistTestCase',
+ 'ArcanistBaseWorkflow' => 'Phobject',
'ArcanistBranchWorkflow' => 'ArcanistBaseWorkflow',
'ArcanistBrowseWorkflow' => 'ArcanistBaseWorkflow',
'ArcanistBundleTestCase' => 'ArcanistTestCase',
@@ -34,7 +34,7 @@
* @group workflow
* @stable
*/
-abstract class ArcanistBaseWorkflow {
+abstract class ArcanistBaseWorkflow extends Phobject {
const COMMIT_DISABLE = 0;
const COMMIT_ALLOW = 1;

0 comments on commit 219dbe2

Please sign in to comment.