Refuse writing to undeclared properties in workflows

Summary: I don't know how to not be strict here plus we (Arcanist developers) don't have access to user's error log. Test Plan: Undeclared `ArcanistDiffWorkflow::$console`, then: $ arc diff Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3607
phacility · Dec 19, 2012 · 219dbe2 · 219dbe2
1 parent 2871d00
commit 219dbe2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
@@ -158,6 +158,7 @@
     'ArcanistApacheLicenseLinterTestCase' => 'ArcanistArcanistLinterTestCase',
     'ArcanistArcanistLinterTestCase' => 'ArcanistLinterTestCase',
     'ArcanistBaseCommitParserTestCase' => 'ArcanistTestCase',
+    'ArcanistBaseWorkflow' => 'Phobject',
     'ArcanistBranchWorkflow' => 'ArcanistBaseWorkflow',
     'ArcanistBrowseWorkflow' => 'ArcanistBaseWorkflow',
     'ArcanistBundleTestCase' => 'ArcanistTestCase',

diff --git a/src/workflow/ArcanistBaseWorkflow.php b/src/workflow/ArcanistBaseWorkflow.php
@@ -34,7 +34,7 @@
  * @group workflow
  * @stable
  */
-abstract class ArcanistBaseWorkflow {
+abstract class ArcanistBaseWorkflow extends Phobject {
 
   const COMMIT_DISABLE = 0;
   const COMMIT_ALLOW = 1;