Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a similar lint rendering issue when trimming identical lines out …
…of patches Summary: Ref T9846. See PHI48. See D18538 for a similar fix. We can contract the suffix lines too much if, e.g, a newline after another newline is removed. Prevent contraction to fewer than 0 lines. Test Plan: Added a failing test, made it pass. Reviewers: chad Reviewed By: chad Subscribers: alexmv Maniphest Tasks: T9846 Differential Revision: https://secure.phabricator.com/D18541
- Loading branch information
epriestley
committed
Sep 6, 2017
1 parent
7371277
commit cbc785d
Showing
4 changed files
with
46 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
>>> Lint for path/to/example.c: | ||
|
||
|
||
Warning (WARN123) Lint Warning | ||
Consider this. | ||
|
||
1 import apple; | ||
2 import banana; | ||
3 ~ | ||
>>> - 4 ~ | ||
5 import cat; | ||
6 import dog; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import apple; | ||
import banana; | ||
|
||
|
||
import cat; | ||
import dog; |