Skip to content

Commit

Permalink
Support synchronous requests
Browse files Browse the repository at this point in the history
Summary:
It is needed in the `unload` handler.
Maybe we can rename it to `blockBrowserUIUntilTheRequestFinishes`.

Test Plan: Used in D3356.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3358
  • Loading branch information
vrana committed Aug 22, 2012
1 parent 65e2438 commit 6bcce58
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/lib/Request.js
Expand Up @@ -142,7 +142,7 @@ JX.install('Request', {
this.getTimeout());
}

xport.open(method, uri, true);
xport.open(method, uri, this.getAsync());

// Must happen after xport.open so that listeners can modify the transport
// Some transport properties can only be set after the transport is open
Expand Down Expand Up @@ -422,6 +422,7 @@ JX.install('Request', {
* @param string HTTP method, one of "POST" or "GET".
*/
method : 'POST',
async : true,
file : null,
raw : false,

Expand Down

0 comments on commit 6bcce58

Please sign in to comment.