Apply linter fixes

Summary: Apply various linter fixes.

Test Plan: Eyeballed it.

Reviewers: chad, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9449

.gitignore

@@ -13,7 +13,7 @@
 /support/jsast/jsast
 /support/jsxmin/jsxmin
 
-# Diviner artifacts 
+# Diviner artifacts
 /docs/
 /.divinercache/
 

LICENSE

@@ -22,4 +22,3 @@ LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-

example/php-tictactoe/ai.php

@@ -57,5 +57,3 @@ function check_win($game, $player) {
 
   return false;
 }
-
-

example/php-typeahead/animals.txt

@@ -179,4 +179,4 @@ wombat
 woodchuck
 yak
 zebra
-zebu
+zebu

scripts/build.sh

@@ -7,5 +7,3 @@ ROOT=`dirname $0`"/../"
 (cd ${ROOT}support/javelinsymbols && make)
 (cd ${ROOT}support/jsast && make)
 (cd ${ROOT}support/jsxmin && make)
-
-

specs/jasmine/jasmine.css

@@ -4,11 +4,11 @@ body {
 
 
 .jasmine_reporter a:visited, .jasmine_reporter a {
-  color: #303; 
+  color: #303;
 }
 
 .jasmine_reporter a:hover, .jasmine_reporter a:active {
-  color: blue; 
+  color: blue;
 }
 
 .run_spec {
@@ -59,7 +59,7 @@ body {
 }
 
 .suite .suite {
-  margin: 5px; 
+  margin: 5px;
 }
 
 .suite.passed {

specs/jasmine/jasmine.js

@@ -116,7 +116,7 @@ jasmine.getEnv = function() {
  * @returns {Boolean}
  */
 jasmine.isArray_ = function(value) {
-  return jasmine.isA_("Array", value);  
+  return jasmine.isA_("Array", value);
 };
 
 /**
@@ -963,7 +963,7 @@ jasmine.Block = function(env, func, spec) {
   this.spec = spec;
 };
 
-jasmine.Block.prototype.execute = function(onComplete) {  
+jasmine.Block.prototype.execute = function(onComplete) {
   try {
     this.func.apply(this.spec);
   } catch (e) {
@@ -1003,7 +1003,7 @@ jasmine.JsApiReporter.prototype.summarize_ = function(suiteOrSpec) {
     type: isSuite ? 'suite' : 'spec',
     children: []
   };
-  
+
   if (isSuite) {
     var children = suiteOrSpec.children();
     for (var i = 0; i < children.length; i++) {
@@ -1704,7 +1704,7 @@ jasmine.Queue.prototype.next_ = function() {
 
   while (goAgain) {
     goAgain = false;
-    
+
     if (self.index < self.blocks.length && !this.abort) {
       var calledSynchronously = true;
       var completedSynchronously = false;
@@ -1742,7 +1742,7 @@ jasmine.Queue.prototype.next_ = function() {
       if (completedSynchronously) {
         onComplete();
       }
-      
+
     } else {
       self.running = false;
       if (self.onComplete) {

src/core/__tests__/event-stop-and-kill.js

@@ -33,7 +33,3 @@ describe('Event Stop/Kill', function() {
     expect(target.getStopped()).toBe(true);
   });
 });
-
-
-
-

src/core/__tests__/install.js

@@ -149,4 +149,3 @@ describe('Javelin Install', function() {
   });
 
 });
-

src/docs/Base.js

@@ -68,8 +68,3 @@ JX.install('Base', {
 
   }
 });
-
-
-
-
-

src/docs/concepts/behaviors.diviner

@@ -179,4 +179,3 @@ The two major downsides to the behavior design appear to be:
     have more than just glue code, and should have been refactored into a
     real class some time ago. This is a pretty high-level drawback and is
     manageable through awareness of the risk and code review.
-

src/docs/onload.js

@@ -19,4 +19,3 @@ JX.onload = function(callback) {
   // This isn't the real function definition, it's only defined here to let the
   // documentation generator find it. The actual definition is in init.js.
 };
-

src/ext/reactor/core/DynVal.js

@@ -45,4 +45,3 @@ JX.install('DynVal', {
       }));
   }
 });
-

src/ext/reactor/core/Reactor.js

@@ -87,4 +87,3 @@ JX.install('Reactor', {
     }
   }
 });
-

src/ext/reactor/core/ReactorNode.js

@@ -94,4 +94,3 @@ JX.install('ReactorNode', {
     }
   }
 });
-

src/ext/reactor/core/ReactorNodeCalmer.js

@@ -45,4 +45,3 @@ JX.install('ReactorNodeCalmer', {
     }
   }
 });
-

src/ext/reactor/dom/RDOM.js

@@ -402,5 +402,3 @@ JX.install('RDOM', {
     }
   }
 });
-
-

src/ext/view/HTMLView.js

@@ -133,4 +133,3 @@ JX.install('HTMLView', {
     }
   }
 });
-

src/ext/view/View.js

@@ -186,4 +186,3 @@ JX.install('View', {
     }
   }
 });
-

src/ext/view/ViewRenderer.js

@@ -16,4 +16,3 @@ JX.install('ViewRenderer', {
     }
   }
 });
-

src/ext/view/ViewVisitor.js

@@ -33,4 +33,3 @@ JX.install('ViewVisitor', {
     }
   }
 });
-

src/lib/DOM.js

@@ -891,4 +891,3 @@ JX.install('DOM', {
     }
   }
 });
-

src/lib/__tests__/URI.js

@@ -262,7 +262,7 @@ describe('Javelin URI', function() {
     expect(uri.toString()).toEqual('/?clown=town');
   });
 
-  it('can remove non existant query data', function() {
+  it('can remove non existent query data', function() {
     var uri = JX.$U('/?key=value');
     uri.addQueryParams({'magic' : null});
     expect(uri.getQueryParams()).toEqual({
@@ -300,4 +300,3 @@ describe('Javelin URI', function() {
   });
 
 });
-

src/lib/__tests__/behavior.js

@@ -93,4 +93,3 @@ describe('Javelin Behaviors', function() {
   });
 
 });
-

src/lib/control/typeahead/source/TypeaheadCompositeSource.js

@@ -75,4 +75,3 @@ JX.install('TypeaheadCompositeSource', {
     }
   }
 });
-

src/lib/control/typeahead/source/TypeaheadOnDemandSource.js

@@ -83,5 +83,3 @@ JX.install('TypeaheadOnDemandSource', {
     }
   }
 });
-
-

src/lib/control/typeahead/source/TypeaheadPreloadedSource.js

@@ -57,6 +57,3 @@ JX.install('TypeaheadPreloadedSource', {
     }
   }
 });
-
-
-

src/lib/control/typeahead/source/TypeaheadStaticSource.js

@@ -35,6 +35,3 @@ JX.install('TypeaheadStaticSource', {
     }
   }
 });
-
-
-

support/diviner/engine/JavelinDivinerEngine.php

@@ -310,7 +310,7 @@ protected function parseMethod(array $ast, $as_function = false) {
 
   protected function failParse(array $ast, $reason) {
     throw new Exception(
-      "Parsing failed at line ".$this->getNodeLine($ast).": ".$reason);
+      'Parsing failed at line '.$this->getNodeLine($ast).': '.$reason);
   }
 
   protected function getObjectLiteralPropertyLine(array $ast, $property) {

support/jsxmin/jsxmin_main.cpp

@@ -26,9 +26,9 @@ static void jsxminify(NodeProgram* root, string &replacements) {
 
 int main(int argc, char* argv[]) {
   try {
-    
+
     string replacements(argc > 1 ? argv[1] : "");
-    
+
     // Create a node.
     NodeProgram root(stdin);
     jsxminify(&root, replacements);

support/jsxmin/jsxmin_reduction.cpp

@@ -15,7 +15,7 @@
 *
 * See accompanying file LICENSE.txt.
 *
-* @author Marcel Laverdet 
+* @author Marcel Laverdet
 */
 
 #include "libfbjs/node.hpp"

support/jsxmin/reduce.cpp

@@ -15,7 +15,7 @@
 *
 * See accompanying file LICENSE.txt.
 *
-* @author Marcel Laverdet 
+* @author Marcel Laverdet
 */
 
 #include "reduce.hpp"
@@ -197,8 +197,8 @@ void ReductionWalker::visit(NodeIf& node) {
       ++it;
       Node* elseBlock = *it;
       if (elseBlock == NULL) {
-        // If we're the child of a statement list, we can safely delete the 
-        // whole if/else node. But if we're a child of an if statement, we can 
+        // If we're the child of a statement list, we can safely delete the
+        // whole if/else node. But if we're a child of an if statement, we can
         // not remove the node or we'll leave the parent with a surprising and
         // segfaulty number of child nodes, e.g. if (x) {} else if (0) {}
         if (dynamic_cast<NodeStatementList*>(parent()->node())) {

support/jsxmin/reduce.hpp

@@ -15,7 +15,7 @@
 *
 * See accompanying file LICENSE.txt.
 *
-* @author Marcel Laverdet 
+* @author Marcel Laverdet
 */
 
 #pragma once