Don't highlight hyperlinks in monospaced text

Summary:
It should be possible to denote unclickable hyperlinks somehow.

NOTE: BC break, it will cause double escaping if applied after EscapeHTML.

Test Plan: Write `Error connecting to http://127.0.0.1/`.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1913

src/markup/engine/remarkup/__tests__/PhutilRemarkupEngineTestCase.php

@@ -60,9 +60,9 @@ private function buildNewTestEngine() {
 
     $rules = array();
     $rules[] = new PhutilRemarkupRuleEscapeRemarkup();
+    $rules[] = new PhutilRemarkupRuleMonospace();
     $rules[] = new PhutilRemarkupRuleHyperlink();
     $rules[] = new PhutilRemarkupRuleEscapeHTML();
-    $rules[] = new PhutilRemarkupRuleMonospace();
     $rules[] = new PhutilRemarkupRuleBold();
     $rules[] = new PhutilRemarkupRuleItalic();
 

src/markup/engine/remarkup/markuprule/monospace/PhutilRemarkupRuleMonospace.php

@@ -32,7 +32,7 @@ public function apply($text) {
   private function markupMonospacedText($matches) {
     $match = isset($matches[2]) ? $matches[2] : $matches[1];
 
-    $result = '<tt>'.$match.'</tt>';
+    $result = '<tt>'.phutil_escape_html($match).'</tt>';
 
     return $this->getEngine()->storeText($result);
   }

src/markup/engine/remarkup/markuprule/monospace/__init__.php

@@ -6,6 +6,7 @@
 
 
 
+phutil_require_module('phutil', 'markup');
 phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/base');