Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove deprecated Maniphest "Can Edit <Specific Property>" capabilities
Summary: Depends on D19579. Fixes T10003. These have been deprecated with a setup warning about their impending removal for about two and a half years. Ref T13164. See PHI642. My overall goal here is to simplify how we handle transactions which have special policy behaviors. In particular, I'm hoping to replace `ApplicationTransactionEditor->requireCapabilities()` with a new, more clear policy check. A problem with `requireCapabilities()` is that it doesn't actually enforce any policies in almost all cases: the default is "nothing", not CAN_EDIT. So it ends up looking like it's the right place to specialize policy checks, but it usually isn't. For "Disable", I need to be able to weaken the check selectively (you can disable users if you have the permission, even if you can't edit them otherwise). We have a handful of other edits which work like this (notably, leaving and joining projects) but they're very rare. Test Plan: Grepped for all removed classes. Edited a Maniphest task. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13164, T10003 Differential Revision: https://secure.phabricator.com/D19581
- Loading branch information
epriestley
committed
Aug 16, 2018
1 parent
f9673a7
commit 296bf04
Showing
10 changed files
with
1 addition
and
208 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 0 additions & 15 deletions
15
src/applications/maniphest/capability/ManiphestEditAssignCapability.php
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
src/applications/maniphest/capability/ManiphestEditPoliciesCapability.php
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
src/applications/maniphest/capability/ManiphestEditPriorityCapability.php
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
src/applications/maniphest/capability/ManiphestEditProjectsCapability.php
This file was deleted.
Oops, something went wrong.
15 changes: 0 additions & 15 deletions
15
src/applications/maniphest/capability/ManiphestEditStatusCapability.php
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
296bf04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this commit broke our install.
Call to undefined method PhabricatorExtraConfigSetupCheck::executeManiphestFieldChecks()
See: https://github.com/phacility/phabricator/blob/master/src/applications/config/check/PhabricatorExtraConfigSetupCheck.php#L88
296bf04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://secure.phabricator.com/D19593, but please report bugs on the Discourse forum (https://discourse.phabricator-community.org), not GitHub.
296bf04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix. I know I should. I was lazy... Sorry!