Various linter fixes.

Summary:
- Removed trailing newlines.
- Added newline at EOF.
- Removed leading newlines.
- Trimmed trailing whitespace.
- Spelling fix.
- Added newline at EOF

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: hach-que, chad, Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8344

conf/production.conf.php

@@ -3,4 +3,3 @@
 return array(
 
 ) + phabricator_read_config_file('default');
-

resources/sql/patches/000.project.sql

@@ -1,4 +1,3 @@
-
 create table {$NAMESPACE}_project.project (
   id int unsigned not null auto_increment primary key,
   name varchar(255) not null,
@@ -28,4 +27,3 @@ create table {$NAMESPACE}_project.project_affiliation (
   dateCreated int unsigned not null,
   dateModified int unsigned not null
 );
-

resources/sql/patches/0000.legacy.sql

@@ -1,9 +1,3 @@
-
-
-
-
-
-
 /*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
 /*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
 /*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;

resources/sql/patches/002.oauth.sql

@@ -15,4 +15,4 @@ insert into {$NAMESPACE}_user.user_oauthinfo
     FROM {$NAMESPACE}_user.user
     WHERE facebookUID is not null;
 
-alter table {$NAMESPACE}_user.user drop facebookUID;
+alter table {$NAMESPACE}_user.user drop facebookUID;

resources/sql/patches/004.daemonrepos.sql

@@ -25,4 +25,4 @@ create table {$NAMESPACE}_timeline.timeline_eventdata (
 create table {$NAMESPACE}_timeline.timeline_cursor (
   name varchar(255) not null primary key,
   position int unsigned not null
-);
+);

resources/sql/patches/005.workers.sql

@@ -1,5 +1,3 @@
-
-
 create table {$NAMESPACE}_worker.worker_task (
   id int unsigned not null auto_increment primary key,
   taskClass varchar(255) not null,

resources/sql/patches/007.daemonlog.sql

@@ -1,5 +1,3 @@
-
-
 create table {$NAMESPACE}_daemon.daemon_log (
   id int unsigned not null auto_increment primary key,
   daemon varchar(255) not null,

resources/sql/patches/009.repo_summary.sql

@@ -4,4 +4,4 @@ CREATE TABLE {$NAMESPACE}_repository.`repository_summary` (
   `lastCommitID` int(10) unsigned NOT NULL,
   `epoch` int(10) unsigned DEFAULT NULL,
   PRIMARY KEY (`repositoryID`)
-);
+);

resources/sql/patches/010.herald.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE {$NAMESPACE}_herald.herald_action (
   id int unsigned not null auto_increment primary key,
   ruleID int unsigned not null,

resources/sql/patches/011.badcommit.sql

@@ -1,4 +1,4 @@
 CREATE TABLE {$NAMESPACE}_repository.repository_badcommit (
   fullCommitName varchar(255) binary not null primary key,
   description longblob not null
-);
+);

resources/sql/patches/012.dropphidtype.sql

@@ -1 +1 @@
-/* This database was later removed entirely. */
+/* This database was later removed entirely. */

resources/sql/patches/016.userrealnameindex.sql

@@ -1 +1 @@
-ALTER TABLE {$NAMESPACE}_user.user ADD key (realName);
+ALTER TABLE {$NAMESPACE}_user.user ADD key (realName);

resources/sql/patches/018.owners.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE {$NAMESPACE}_owners.owners_package (
   id int unsigned not null auto_increment primary key,
   phid varchar(64) binary not null,

resources/sql/patches/020.pathcapital.sql

@@ -1,2 +1,2 @@
 ALTER TABLE {$NAMESPACE}_differential.differential_diff
-  CHANGE sourceControlpath sourceControlPath varchar(255);
+  CHANGE sourceControlpath sourceControlPath varchar(255);

resources/sql/patches/021.xhpastview.sql

@@ -1,4 +1,3 @@
-
 CREATE TABLE {$NAMESPACE}_xhpastview.xhpastview_parsetree (
   id int unsigned not null auto_increment primary key,
   authorPHID varchar(64) binary,

resources/sql/patches/024.mlistkeys.sql

@@ -3,4 +3,3 @@ ALTER TABLE {$NAMESPACE}_metamta.metamta_mailinglist
 
 ALTER TABLE {$NAMESPACE}_metamta.metamta_mailinglist
   ADD UNIQUE KEY (name);
-

resources/sql/patches/025.commentopt.sql

@@ -1,2 +1,2 @@
 ALTER TABLE {$NAMESPACE}_differential.differential_inlinecomment
-  ADD KEY (revisionID, authorPHID);
+  ADD KEY (revisionID, authorPHID);

resources/sql/patches/026.diffpropkey.sql

@@ -1,3 +1,2 @@
 ALTER TABLE {$NAMESPACE}_differential.differential_diffproperty
   ADD UNIQUE KEY (diffID, name);
-

resources/sql/patches/028.systemagent.sql

@@ -1,2 +1,2 @@
 ALTER TABLE {$NAMESPACE}_user.user
-  ADD isSystemAgent bool not null default 0;
+  ADD isSystemAgent bool not null default 0;

resources/sql/patches/034.savedheader.sql

@@ -1,4 +1,4 @@
 CREATE TABLE {$NAMESPACE}_herald.herald_savedheader (
   phid varchar(64) binary not null primary key,
   header varchar(255) not null
-) ENGINE=InnoDB;
+) ENGINE=InnoDB;

resources/sql/patches/036.mailkey.sql

@@ -16,4 +16,4 @@ CREATE TABLE {$NAMESPACE}_metamta.metamta_receivedmail (
   message longblob,
   dateCreated int unsigned not null,
   dateModified int unsigned not null
-) engine=innodb;
+) engine=innodb;

resources/sql/patches/043.pastebin.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE {$NAMESPACE}_pastebin.pastebin_paste (
   id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
   title VARCHAR(255) NOT NULL,

resources/sql/patches/044.countdown.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE {$NAMESPACE}_countdown.countdown_timer (
   id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
   title VARCHAR(255) NOT NULL,

resources/sql/patches/047.projectstatus.sql

@@ -1,2 +1,2 @@
 ALTER TABLE {$NAMESPACE}_project.project
-  ADD status varchar(32) not null;
+  ADD status varchar(32) not null;

resources/sql/patches/049.projectowner.sql

@@ -1,2 +1,2 @@
 ALTER TABLE {$NAMESPACE}_project.project_affiliation
-  ADD isOwner bool NOT NULL;
+  ADD isOwner bool NOT NULL;

resources/sql/patches/052.pastelanguage.sql

@@ -1,2 +1,2 @@
 ALTER TABLE {$NAMESPACE}_pastebin.pastebin_paste
-  ADD COLUMN language VARCHAR(64) NOT NULL;
+  ADD COLUMN language VARCHAR(64) NOT NULL;

resources/sql/patches/053.feed.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE {$NAMESPACE}_feed.feed_storydata (
   id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
   phid VARCHAR(64) BINARY NOT NULL,

resources/sql/patches/055.add_author_to_files.sql

@@ -1,3 +1,3 @@
 ALTER TABLE {$NAMESPACE}_file.file
   ADD COLUMN authorPHID VARCHAR(64) BINARY,
-  ADD KEY (authorPHID);
+  ADD KEY (authorPHID);

resources/sql/patches/056.slowvote.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE {$NAMESPACE}_slowvote.slowvote_poll (
   id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
   question VARCHAR(255) NOT NULL,
@@ -41,4 +39,4 @@ CREATE TABLE {$NAMESPACE}_slowvote.slowvote_choice (
   KEY (authorPHID),
   dateCreated INT UNSIGNED NOT NULL,
   dateModified INT UNSIGNED NOT NULL
-);
+);

resources/sql/patches/057.parsecache.sql

@@ -4,4 +4,4 @@ ALTER TABLE {$NAMESPACE}_differential.differential_changeset_parse_cache
   ADD dateCreated INT UNSIGNED NOT NULL;
 
 ALTER TABLE {$NAMESPACE}_differential.differential_changeset_parse_cache
-  ADD KEY (dateCreated);
+  ADD KEY (dateCreated);

resources/sql/patches/058.missingkeys.sql

@@ -8,4 +8,4 @@ ALTER TABLE {$NAMESPACE}_herald.herald_condition
   ADD KEY (ruleID);
 
 ALTER TABLE {$NAMESPACE}_herald.herald_action
-  ADD KEY (ruleID);
+  ADD KEY (ruleID);

resources/sql/patches/060.phriction.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE {$NAMESPACE}_phriction.phriction_document (
   id INT UNSIGNED NOT NULL,
   phid VARCHAR(64) BINARY NOT NULL,

resources/sql/patches/061.phrictioncontent.sql

@@ -19,4 +19,4 @@ CREATE TABLE {$NAMESPACE}_phriction.phriction_content (
   content LONGBLOB NOT NULL,
   dateCreated INT UNSIGNED NOT NULL,
   dateModified INT UNSIGNED NOT NULL
-) ENGINE=InnoDB;
+) ENGINE=InnoDB;

resources/sql/patches/062.phrictionmenu.sql

@@ -1,3 +1,3 @@
 /* Older versions incorrectly computed the depth for the root page. */
 UPDATE {$NAMESPACE}_phriction.phriction_document
-  SET depth = 0 where slug = '/';
+  SET depth = 0 where slug = '/';

resources/sql/patches/063.pasteforks.sql

@@ -1,3 +1,3 @@
 ALTER TABLE {$NAMESPACE}_pastebin.pastebin_paste
   ADD COLUMN parentPHID VARCHAR(64) BINARY,
-  ADD KEY (parentPHID);
+  ADD KEY (parentPHID);

resources/sql/patches/064.subprojects.sql

@@ -8,4 +8,4 @@ CREATE TABLE {$NAMESPACE}_project.project_subproject (
   subprojectPHID varchar(64) BINARY NOT NULL,
   PRIMARY KEY (subprojectPHID, projectPHID),
   UNIQUE KEY (projectPHID, subprojectPHID)
-) ENGINE=InnoDB;
+) ENGINE=InnoDB;

resources/sql/patches/065.sshkeys.sql

@@ -9,4 +9,4 @@ CREATE TABLE {$NAMESPACE}_user.user_sshkey (
   keyComment varchar(255),
   dateCreated INT UNSIGNED NOT NULL,
   dateModified INT UNSIGNED NOT NULL
-) ENGINE=InnoDB;
+) ENGINE=InnoDB;

resources/sql/patches/067.preferences.sql

@@ -1 +1 @@
-/* This used to be a "directory" update. */;
+/* This used to be a "directory" update. */;

resources/sql/patches/068.maniphestauxiliarystorage.sql

@@ -1,9 +1,9 @@
-create table {$NAMESPACE}_maniphest.maniphest_taskauxiliarystorage 
+create table {$NAMESPACE}_maniphest.maniphest_taskauxiliarystorage
     (id int unsigned not null auto_increment primary key,
-    taskPHID varchar(64) binary not null, 
-    name varchar(255) not null, 
-    value varchar(255) not null, 
+    taskPHID varchar(64) binary not null,
+    name varchar(255) not null,
+    value varchar(255) not null,
     unique key (taskPHID,name),
     dateCreated int unsigned not null,
     dateModified int unsigned not null)
-    ENGINE = InnoDB;
+    ENGINE = InnoDB;

resources/sql/patches/076.indexedlanguages.sql

@@ -1,4 +1,4 @@
 ALTER TABLE {$NAMESPACE}_repository.repository_arcanistproject
   ADD symbolIndexLanguages LONGBLOB NOT NULL;
 ALTER TABLE {$NAMESPACE}_repository.repository_arcanistproject
-  ADD symbolIndexProjects LONGBLOB NOT NULL;
+  ADD symbolIndexProjects LONGBLOB NOT NULL;

resources/sql/patches/080.filekeys.sql

@@ -1,2 +1,2 @@
 ALTER TABLE {$NAMESPACE}_file.file
-  ADD secretKey VARCHAR(20) BINARY;
+  ADD secretKey VARCHAR(20) BINARY;

resources/sql/patches/086.formeraffil.sql

@@ -1 +1 @@
-ALTER TABLE {$NAMESPACE}_project.project_affiliation DROP status;
+ALTER TABLE {$NAMESPACE}_project.project_affiliation DROP status;

resources/sql/patches/087.phrictiondelete.sql

@@ -5,4 +5,4 @@ ALTER TABLE {$NAMESPACE}_phriction.phriction_content
   ADD changeType INT UNSIGNED NOT NULL DEFAULT 0;
 
 ALTER TABLE {$NAMESPACE}_phriction.phriction_content
-  ADD changeRef INT UNSIGNED DEFAULT NULL;
+  ADD changeRef INT UNSIGNED DEFAULT NULL;

resources/sql/patches/088.audit.sql

@@ -1,5 +1,3 @@
-
-
 ALTER TABLE {$NAMESPACE}_owners.owners_packagecommitrelationship
   ADD COLUMN `auditStatus` varchar(64) NOT NULL,
   ADD COLUMN `auditReasons` longtext NOT NULL,

resources/sql/patches/092.dropgithubnotification.sql

@@ -1 +1 @@
-DROP TABLE {$NAMESPACE}_repository.repository_githubnotification;
+DROP TABLE {$NAMESPACE}_repository.repository_githubnotification;

resources/sql/patches/095.directory.sql

@@ -1 +1 @@
-/* This used to be a "directory" update. */;
+/* This used to be a "directory" update. */;

resources/sql/patches/097.heraldruletypes.sql

@@ -1,2 +1,2 @@
 ALTER TABLE {$NAMESPACE}_herald.herald_rule ADD ruleType varchar(255) not null DEFAULT 'global';
-CREATE INDEX IDX_RULE_TYPE on {$NAMESPACE}_herald.herald_rule (ruleType);
+CREATE INDEX IDX_RULE_TYPE on {$NAMESPACE}_herald.herald_rule (ruleType);

resources/sql/patches/099.drydock.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE {$NAMESPACE}_drydock.drydock_resource (
   id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
   phid VARCHAR(64) BINARY NOT NULL,

resources/sql/patches/106.chatlog.sql

@@ -1,4 +1,3 @@
-
 CREATE TABLE {$NAMESPACE}_chatlog.chatlog_event (
   id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT,
   channel VARCHAR(64) BINARY NOT NULL,

resources/sql/patches/107.oauthserver.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserverclient` (
   `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
   `phid` varchar(64) BINARY NOT NULL,
@@ -48,4 +46,3 @@ CREATE TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserveraccesstoken` (
   PRIMARY KEY (`id`),
   UNIQUE KEY `token` (`token`)
 ) ENGINE=InnoDB;
-

resources/sql/patches/108.oauthscope.sql

@@ -3,4 +3,3 @@ ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthclientauthorization`
 
 ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserveraccesstoken`
   DROP `dateExpires`;
-

resources/sql/patches/109.oauthclientphidkey.sql

@@ -1,3 +1,2 @@
 ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserverclient`
   ADD KEY `creatorPHID` (`creatorPHID`)
-

resources/sql/patches/110.commitaudit.sql

@@ -8,4 +8,4 @@ ALTER TABLE {$NAMESPACE}_repository.repository_commit
   ADD auditStatus INT UNSIGNED NOT NULL;
 
 ALTER TABLE {$NAMESPACE}_repository.repository_commit
-  ADD KEY (authorPHID, auditStatus, epoch);
+  ADD KEY (authorPHID, auditStatus, epoch);

resources/sql/patches/112.oauthaccesscoderedirecturi.sql

@@ -1,3 +1,2 @@
 ALTER TABLE `{$NAMESPACE}_oauth_server`.`oauth_server_oauthserverauthorizationcode`
   ADD `redirectURI` varchar(255) NOT NULL
-

resources/sql/patches/116.utf8-backup-first-expect-wait.sql

@@ -1123,6 +1123,3 @@ ALTER TABLE `{$NAMESPACE}_xhpastview`.`xhpastview_parsetree`
   MODIFY `authorPHID` varchar(64) COLLATE utf8_bin,
   MODIFY `input` longtext COLLATE utf8_bin NOT NULL,
   MODIFY `stdout` longtext COLLATE utf8_bin NOT NULL;
-
-
-

resources/sql/patches/120.noop.sql

@@ -1,2 +1,2 @@
 /* Do nothing, patch 121 got committed before there was a patch 120. */
-SELECT 1;
+SELECT 1;

resources/sql/patches/122.flag.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE {$NAMESPACE}_flag.flag (
   id INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
   ownerPHID varchar(64) COLLATE utf8_bin NOT NULL,
@@ -13,4 +11,4 @@ CREATE TABLE {$NAMESPACE}_flag.flag (
 
   UNIQUE KEY (ownerPHID, type, objectPHID),
   KEY (objectPHID)
-) ENGINE=InnoDB;
+) ENGINE=InnoDB;

resources/sql/patches/124.subpriority.sql

@@ -7,5 +7,3 @@ ALTER TABLE {$NAMESPACE}_maniphest.maniphest_task
 /* Seed the subpriority column with reasonable values that keep order stable. */
 UPDATE {$NAMESPACE}_maniphest.maniphest_task
   SET subpriority = (UNIX_TIMESTAMP() - dateModified);
-
-

resources/sql/patches/128.phabricatorcom.sql

@@ -1 +1 @@
-/* This used to be a "directory" update. */;
+/* This used to be a "directory" update. */;

resources/sql/patches/132.phame.sql

@@ -1,5 +1,3 @@
-
-
 CREATE TABLE `{$NAMESPACE}_phame`.`phame_post` (
   `id` INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
   `phid` VARCHAR(64) BINARY NOT NULL COLLATE utf8_bin,

resources/sql/patches/20121209.pholioxactions.sql

@@ -48,4 +48,3 @@ CREATE TABLE {$NAMESPACE}_pholio.pholio_transaction_comment (
   UNIQUE KEY `key_draft` (authorPHID, mockID, transactionPHID)
 
 ) ENGINE=InnoDB, COLLATE utf8_general_ci;
-

resources/sql/patches/20130111.conpherence.sql

@@ -1,4 +1,3 @@
-
 CREATE TABLE {$NAMESPACE}_conpherence.conpherence_thread (
   id INT UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT,
   phid VARCHAR(64) NOT NULL COLLATE utf8_bin,
@@ -80,4 +79,3 @@ CREATE TABLE {$NAMESPACE}_conpherence.conpherence_transaction_comment (
   UNIQUE KEY `key_draft` (authorPHID, conpherencePHID, transactionPHID)
 
 ) ENGINE=InnoDB, COLLATE utf8_general_ci;
-

resources/sql/patches/20130127.altheraldtranscript.sql

@@ -1,3 +1,2 @@
 ALTER TABLE `{$NAMESPACE}_herald`.`herald_transcript`
   DROP `psth`;
-