Skip to content

Commit

Permalink
Make printing workboards work OK
Browse files Browse the repository at this point in the history
Summary:
Fixes T7844. This isn't going to win any awards, but it has all the information.

Mostly, we don't (or shouldn't, at least?) need the global `static` stuff anymore because we dropped the top-level custom scrollbar.

Test Plan: Printed a PDF of a workboard, got all the cards in the output.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7844

Differential Revision: https://secure.phabricator.com/D15205
  • Loading branch information
epriestley committed Feb 7, 2016
1 parent a45fe33 commit 73f5ff0
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 19 deletions.
14 changes: 7 additions & 7 deletions resources/celerity/map.php
Expand Up @@ -7,7 +7,7 @@
*/
return array(
'names' => array(
'core.pkg.css' => 'a7d4cf8f',
'core.pkg.css' => 'b4a7e275',
'core.pkg.js' => '808ae845',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '2de124c9',
Expand Down Expand Up @@ -36,7 +36,7 @@
'rsrc/css/application/base/notification-menu.css' => 'f31c0bde',
'rsrc/css/application/base/phabricator-application-launch-view.css' => '95351601',
'rsrc/css/application/base/phui-theme.css' => 'ab7b848c',
'rsrc/css/application/base/standard-page-view.css' => 'c4467133',
'rsrc/css/application/base/standard-page-view.css' => 'e709f6d0',
'rsrc/css/application/chatlog/chatlog.css' => 'd295b020',
'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
'rsrc/css/application/config/config-options.css' => '0ede4c9b',
Expand Down Expand Up @@ -146,15 +146,15 @@
'rsrc/css/phui/phui-object-item-list-view.css' => '8f443e8b',
'rsrc/css/phui/phui-pager.css' => 'bea33d23',
'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
'rsrc/css/phui/phui-profile-menu.css' => 'ab4fcf5f',
'rsrc/css/phui/phui-profile-menu.css' => '4a243229',
'rsrc/css/phui/phui-property-list-view.css' => '27b2849e',
'rsrc/css/phui/phui-remarkup-preview.css' => '1a8f2591',
'rsrc/css/phui/phui-spacing.css' => '042804d6',
'rsrc/css/phui/phui-status.css' => '888cedb8',
'rsrc/css/phui/phui-tag-view.css' => '9d5d4400',
'rsrc/css/phui/phui-timeline-view.css' => '2efceff8',
'rsrc/css/phui/phui-two-column-view.css' => 'c75bfc5b',
'rsrc/css/phui/workboards/phui-workboard.css' => 'b07a5524',
'rsrc/css/phui/workboards/phui-workboard.css' => '2a04b1a8',
'rsrc/css/phui/workboards/phui-workcard.css' => 'a869098a',
'rsrc/css/phui/workboards/phui-workpanel.css' => 'e1bd8d04',
'rsrc/css/sprite-login.css' => '60e8560e',
Expand Down Expand Up @@ -764,7 +764,7 @@
'phabricator-side-menu-view-css' => '3a3d9f41',
'phabricator-slowvote-css' => 'da0afb1b',
'phabricator-source-code-view-css' => 'cbeef983',
'phabricator-standard-page-view' => 'c4467133',
'phabricator-standard-page-view' => 'e709f6d0',
'phabricator-textareautils' => '9e54692d',
'phabricator-title' => 'df5e11d2',
'phabricator-tooltip' => '6323f942',
Expand Down Expand Up @@ -822,7 +822,7 @@
'phui-object-item-list-view-css' => '8f443e8b',
'phui-pager-css' => 'bea33d23',
'phui-pinboard-view-css' => '2495140e',
'phui-profile-menu-css' => 'ab4fcf5f',
'phui-profile-menu-css' => '4a243229',
'phui-property-list-view-css' => '27b2849e',
'phui-remarkup-preview-css' => '1a8f2591',
'phui-spacing-css' => '042804d6',
Expand All @@ -831,7 +831,7 @@
'phui-theme-css' => 'ab7b848c',
'phui-timeline-view-css' => '2efceff8',
'phui-two-column-view-css' => 'c75bfc5b',
'phui-workboard-view-css' => 'b07a5524',
'phui-workboard-view-css' => '2a04b1a8',
'phui-workcard-view-css' => 'a869098a',
'phui-workpanel-view-css' => 'e1bd8d04',
'phuix-action-list-view' => 'b5c256b8',
Expand Down
12 changes: 0 additions & 12 deletions webroot/rsrc/css/application/base/standard-page-view.css
Expand Up @@ -136,18 +136,6 @@ a.handle-availability-disabled {
right: 0;
}

/* Fixes so pages actually print when magic scrollbar is present */
!print .main-page-frame {
position: static;
overflow: visible;
}

!print .jx-scrollbar-viewport {
position: static;
width: auto !important;
height: auto !important;
}

.jx-scrollbar-test {
position: absolute;
left: -300px;
Expand Down
4 changes: 4 additions & 0 deletions webroot/rsrc/css/phui/phui-profile-menu.css
Expand Up @@ -300,3 +300,7 @@
max-width: {$menu.profile.width};
}
}

!print .phui-profile-menu .phabricator-side-menu {
display: none;
}
10 changes: 10 additions & 0 deletions webroot/rsrc/css/phui/workboards/phui-workboard.css
Expand Up @@ -52,6 +52,16 @@
left: {$menu.profile.width.collapsed};
}

!print .project-board-wrapper .phui-workboard-view-shadow {
position: static;
}

!print .project-board-wrapper .aphront-multi-column-column-outer {
display: block;
margin: 0 0 18px;
page-break-inside: avoid;
}

.device-desktop .phui-workboard-view .aphront-multi-column-fixed
.aphront-multi-column-inner {
margin-left: 0;
Expand Down

0 comments on commit 73f5ff0

Please sign in to comment.