Extend from Phobject

Summary: All classes should extend from some other class. See D13275 for some explanation.

Test Plan: `arc unit`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13283

src/aphront/AphrontRequest.php

@@ -5,7 +5,7 @@
  * @task cookie   Managing Cookies
  * @task cluster  Working With a Phabricator Cluster
  */
-final class AphrontRequest {
+final class AphrontRequest extends Phobject {
 
   // NOTE: These magic request-type parameters are automatically included in
   // certain requests (e.g., by phabricator_form(), JX.Request,
@@ -27,6 +27,7 @@ final class AphrontRequest {
   private $user;
   private $applicationConfiguration;
   private $uriData;
+  private $cookiePrefix;
 
   public function __construct($host, $path) {
     $this->host = $host;

src/aphront/AphrontURIMapper.php

@@ -1,6 +1,6 @@
 <?php
 
-final class AphrontURIMapper {
+final class AphrontURIMapper extends Phobject {
 
   private $map;
 

src/aphront/configuration/AphrontApplicationConfiguration.php

@@ -3,7 +3,7 @@
 /**
  * @task  routing URI Routing
  */
-abstract class AphrontApplicationConfiguration {
+abstract class AphrontApplicationConfiguration extends Phobject {
 
   private $request;
   private $host;

src/aphront/response/AphrontResponse.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class AphrontResponse {
+abstract class AphrontResponse extends Phobject {
 
   private $request;
   private $cacheable = false;

src/aphront/sink/AphrontHTTPSink.php

@@ -11,7 +11,7 @@
  * @task write  Writing Response Components
  * @task emit   Emitting the Response
  */
-abstract class AphrontHTTPSink {
+abstract class AphrontHTTPSink extends Phobject {
 
 
 /* -(  Writing Response Components  )---------------------------------------- */

src/applications/aphlict/query/AphlictDropdownDataQuery.php

@@ -1,6 +1,6 @@
 <?php
 
-final class AphlictDropdownDataQuery {
+final class AphlictDropdownDataQuery extends Phobject {
 
   private $viewer;
   private $notificationData;

src/applications/audit/constants/PhabricatorAuditActionConstants.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorAuditActionConstants {
+final class PhabricatorAuditActionConstants extends Phobject {
 
   const CONCERN   = 'concern';
   const ACCEPT    = 'accept';

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorAuditCommitStatusConstants {
+final class PhabricatorAuditCommitStatusConstants extends Phobject {
 
   const NONE                = 0;
   const NEEDS_AUDIT         = 1;

src/applications/audit/constants/PhabricatorAuditStatusConstants.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorAuditStatusConstants {
+final class PhabricatorAuditStatusConstants extends Phobject {
 
   const NONE                    = '';
   const AUDIT_NOT_REQUIRED      = 'audit-not-required';

src/applications/audit/storage/PhabricatorAuditInlineComment.php

@@ -1,6 +1,7 @@
 <?php
 
 final class PhabricatorAuditInlineComment
+  extends Phobject
   implements PhabricatorInlineCommentInterface {
 
   private $proxy;

src/applications/auth/data/PhabricatorAuthHighSecurityToken.php

@@ -1,3 +1,3 @@
 <?php
 
-final class PhabricatorAuthHighSecurityToken {}
+final class PhabricatorAuthHighSecurityToken extends Phobject {}

src/applications/auth/provider/PhabricatorAuthProvider.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class PhabricatorAuthProvider {
+abstract class PhabricatorAuthProvider extends Phobject {
 
   private $providerConfig;
 

src/applications/base/PhabricatorApplication.php

@@ -8,7 +8,9 @@
  * @task  fact  Fact Integration
  * @task  meta  Application Management
  */
-abstract class PhabricatorApplication implements PhabricatorPolicyInterface {
+abstract class PhabricatorApplication
+  extends Phobject
+  implements PhabricatorPolicyInterface {
 
   const MAX_STATUS_ITEMS      = 100;
 

src/applications/cache/PhabricatorCaches.php

@@ -7,7 +7,7 @@
  * @task setup      Setup Cache
  * @task compress   Compression
  */
-final class PhabricatorCaches {
+final class PhabricatorCaches extends Phobject {
 
   private static $requestCache;
 

src/applications/calendar/util/CalendarTimeUtil.php

@@ -10,7 +10,7 @@
  * a Sunday -> Saturday list, whilest the profile view shows a more simple
  * seven day rolling list of events.
  */
-final class CalendarTimeUtil {
+final class CalendarTimeUtil extends Phobject {
 
   public static function getCalendarEventEpochs(
     PhabricatorUser $user,

src/applications/celerity/CelerityAPI.php

@@ -4,7 +4,7 @@
  * Indirection layer which provisions for a terrifying future where we need to
  * build multiple resource responses per page.
  */
-final class CelerityAPI {
+final class CelerityAPI extends Phobject {
 
   private static $response;
 

src/applications/celerity/CelerityResourceMap.php

@@ -6,7 +6,7 @@
  * not need to invoke it directly; instead, you call higher-level Celerity APIs
  * and it uses the resource map to satisfy your requests.
  */
-final class CelerityResourceMap {
+final class CelerityResourceMap extends Phobject {
 
   private static $instances = array();
 
@@ -16,6 +16,7 @@ final class CelerityResourceMap {
   private $packageMap;
   private $nameMap;
   private $hashMap;
+  private $componentMap;
 
   public function __construct(CelerityResources $resources) {
     $this->resources = $resources;

src/applications/celerity/CelerityResourceMapGenerator.php

@@ -1,6 +1,6 @@
 <?php
 
-final class CelerityResourceMapGenerator {
+final class CelerityResourceMapGenerator extends Phobject {
 
   private $debug = false;
   private $resources;

src/applications/celerity/CelerityResourceTransformer.php

@@ -1,6 +1,6 @@
 <?php
 
-final class CelerityResourceTransformer {
+final class CelerityResourceTransformer extends Phobject {
 
   private $minify;
   private $rawURIMap;

src/applications/celerity/CeleritySpriteGenerator.php

@@ -1,6 +1,6 @@
 <?php
 
-final class CeleritySpriteGenerator {
+final class CeleritySpriteGenerator extends Phobject {
 
   public function buildMenuSheet() {
     $sprites = array();

src/applications/celerity/CelerityStaticResourceResponse.php

@@ -5,7 +5,7 @@
  * @{function:require_celerity_resource}, and then builds appropriate HTML or
  * Ajax responses.
  */
-final class CelerityStaticResourceResponse {
+final class CelerityStaticResourceResponse extends Phobject {
 
   private $symbols = array();
   private $needsResolve = true;

src/applications/celerity/resources/CelerityResources.php

@@ -3,7 +3,7 @@
 /**
  * Defines the location of static resources.
  */
-abstract class CelerityResources {
+abstract class CelerityResources extends Phobject {
 
   private $map;
 

src/applications/conduit/call/ConduitCall.php

@@ -8,9 +8,10 @@
  *   $result = $call->execute();
  *
  */
-final class ConduitCall {
+final class ConduitCall extends Phobject {
 
   private $method;
+  private $handler;
   private $request;
   private $user;
 

src/applications/conduit/protocol/ConduitAPIRequest.php

@@ -1,6 +1,6 @@
 <?php
 
-final class ConduitAPIRequest {
+final class ConduitAPIRequest extends Phobject {
 
   protected $params;
   private $user;

src/applications/conduit/protocol/ConduitAPIResponse.php

@@ -1,6 +1,6 @@
 <?php
 
-final class ConduitAPIResponse {
+final class ConduitAPIResponse extends Phobject {
 
   private $result;
   private $errorCode;

src/applications/config/check/PhabricatorSetupCheck.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class PhabricatorSetupCheck {
+abstract class PhabricatorSetupCheck extends Phobject {
 
   private $issues;
 

src/applications/config/custom/PhabricatorConfigOptionType.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class PhabricatorConfigOptionType {
+abstract class PhabricatorConfigOptionType extends Phobject {
 
   public function validateOption(PhabricatorConfigOption $option, $value) {
     return;

src/applications/config/issue/PhabricatorSetupIssue.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorSetupIssue {
+final class PhabricatorSetupIssue extends Phobject {
 
   private $issueKey;
   private $name;

src/applications/config/json/PhabricatorConfigJSON.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorConfigJSON {
+final class PhabricatorConfigJSON extends Phobject {
   /**
    * Properly format a JSON value.
    *

src/applications/conpherence/ConpherenceTransactionRenderer.php

@@ -1,6 +1,6 @@
 <?php
 
-final class ConpherenceTransactionRenderer {
+final class ConpherenceTransactionRenderer extends Phobject {
 
   public static function renderTransactions(
     PhabricatorUser $user,

src/applications/conpherence/constants/ConpherenceConstants.php

@@ -1,3 +1,3 @@
 <?php
 
-abstract class ConpherenceConstants {}
+abstract class ConpherenceConstants extends Phobject {}

src/applications/console/core/DarkConsoleCore.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DarkConsoleCore {
+final class DarkConsoleCore extends Phobject {
 
   private $plugins = array();
   const STORAGE_VERSION = 1;

src/applications/console/plugin/DarkConsolePlugin.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class DarkConsolePlugin {
+abstract class DarkConsolePlugin extends Phobject {
 
   private $data;
   private $request;

src/applications/console/plugin/errorlog/DarkConsoleErrorLogPluginAPI.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DarkConsoleErrorLogPluginAPI {
+final class DarkConsoleErrorLogPluginAPI extends Phobject {
 
   private static $errors = array();
 

src/applications/console/plugin/xhprof/DarkConsoleXHProfPluginAPI.php

@@ -4,7 +4,7 @@
  * @phutil-external-symbol function xhprof_enable
  * @phutil-external-symbol function xhprof_disable
  */
-final class DarkConsoleXHProfPluginAPI {
+final class DarkConsoleXHProfPluginAPI extends Phobject {
 
   private static $profilerStarted;
   private static $profilerRunning;

src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php

@@ -1,6 +1,6 @@
 <?php
 
-final class PhabricatorDashboardLayoutConfig {
+final class PhabricatorDashboardLayoutConfig extends Phobject {
 
   const MODE_FULL                = 'layout-mode-full';
   const MODE_HALF_AND_HALF       = 'layout-mode-half-and-half';

src/applications/differential/DifferentialGetWorkingCopy.php

@@ -4,7 +4,7 @@
  * Can't find a good place for this, so I'm putting it in the most notably
  * wrong place.
  */
-final class DifferentialGetWorkingCopy {
+final class DifferentialGetWorkingCopy extends Phobject {
 
   /**
    * Creates and/or cleans a workspace for the requested repo.

src/applications/differential/constants/DifferentialAction.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialAction {
+final class DifferentialAction extends Phobject {
 
   const ACTION_CLOSE          = 'commit';
   const ACTION_COMMENT        = 'none';

src/applications/differential/constants/DifferentialChangeType.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialChangeType {
+final class DifferentialChangeType extends Phobject {
 
   const TYPE_ADD        = 1;
   const TYPE_CHANGE     = 2;

src/applications/differential/constants/DifferentialLintStatus.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialLintStatus {
+final class DifferentialLintStatus extends Phobject {
 
   const LINT_NONE             = 0;
   const LINT_OKAY             = 1;

src/applications/differential/constants/DifferentialReviewerStatus.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialReviewerStatus {
+final class DifferentialReviewerStatus extends Phobject {
 
   const STATUS_BLOCKING = 'blocking';
   const STATUS_ADDED = 'added';

src/applications/differential/constants/DifferentialRevisionControlSystem.php

@@ -1,7 +1,7 @@
 <?php
 
 // TODO: Unify with similar Repository constants
-final class DifferentialRevisionControlSystem {
+final class DifferentialRevisionControlSystem extends Phobject {
 
   const SVN         = 'svn';
   const GIT         = 'git';

src/applications/differential/constants/DifferentialRevisionStatus.php

@@ -6,7 +6,7 @@
  * application.
  */
 
-final class DifferentialRevisionStatus {
+final class DifferentialRevisionStatus extends Phobject {
 
   const COLOR_STATUS_DEFAULT = 'status';
   const COLOR_STATUS_DARK = 'status-dark';

src/applications/differential/constants/DifferentialUnitStatus.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialUnitStatus {
+final class DifferentialUnitStatus extends Phobject {
 
   const UNIT_NONE             = 0;
   const UNIT_OKAY             = 1;

src/applications/differential/constants/DifferentialUnitTestResult.php

@@ -1,6 +1,6 @@
 <?php
 
-final class DifferentialUnitTestResult {
+final class DifferentialUnitTestResult extends Phobject {
 
   const RESULT_PASS         = 'pass';
   const RESULT_FAIL         = 'fail';

src/applications/differential/landing/DifferentialLandingStrategy.php

@@ -1,6 +1,6 @@
 <?php
 
-abstract class DifferentialLandingStrategy {
+abstract class DifferentialLandingStrategy extends Phobject {
 
   abstract public function processLandRequest(
     AphrontRequest $request,