Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __set_state #14212

Closed
niden opened this issue Jun 26, 2019 · 3 comments

Comments

@niden
Copy link
Member

commented Jun 26, 2019

Check where __set_state() is used and remove it accordingly.

@niden niden added this to To do in 4.0 Release via automation Jun 26, 2019

@SidRoberts SidRoberts self-assigned this Jun 26, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 26, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 26, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 26, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 26, 2019

@scrnjakovic

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

There is some in Phalcon\Config afair.

@CameronHall

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

@scrnjakovic it was removed in #14186 :)

@niden niden moved this from To do to In progress in 4.0 Release Jun 28, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 29, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 29, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 29, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 29, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 29, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 29, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 29, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 29, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 29, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 30, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 30, 2019

niden added a commit to niden/cphalcon that referenced this issue Jun 30, 2019

@niden niden referenced this issue Jun 30, 2019

Merged

T14212 set state #14223

4 of 5 tasks complete

niden added a commit that referenced this issue Jun 30, 2019

niden added a commit that referenced this issue Jun 30, 2019

@niden

This comment has been minimized.

Copy link
Member Author

commented Jun 30, 2019

Addressed in #14223

@niden niden closed this Jun 30, 2019

4.0 Release automation moved this from In progress to Done Jun 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.