Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove __set_state #14212

Closed
niden opened this issue Jun 26, 2019 · 3 comments
Closed

Remove __set_state #14212

niden opened this issue Jun 26, 2019 · 3 comments
Assignees
@SidRoberts
Labels
enhancement Enhancement to the framework
Projects
4.0.0 Release

Comments

@niden
Copy link
Sponsor Member

niden commented Jun 26, 2019

Check where __set_state() is used and remove it accordingly.
@niden niden added 4.0 enhancement Enhancement to the framework labels Jun 26, 2019
@niden niden added this to To do in 4.0.0 Release via automation Jun 26, 2019
@SidRoberts SidRoberts self-assigned this Jun 26, 2019
@scrnjakovic
Copy link
Contributor

There is some in Phalcon\Config afair.

@CameronHall
Copy link
Contributor

@scrnjakovic it was removed in #14186 :)

@niden niden moved this from To do to In progress in 4.0.0 Release Jun 28, 2019
@niden niden mentioned this issue Jun 30, 2019
Merged
5 tasks
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - Changes to the tests - removing __set_state
dcae374
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - Removing __set_state; Adjustments to the request
a5e0ca8
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - Corrected changelog; temp remove integration tests
c5ba16c
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - Test corrections
b4356ea
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - More corrections
20cc545
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - Correcting set_state in tests
e4e7027
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - Refactoring tests for set_state
ff80a81
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - More refactoring for _set_state; Added numeric types for s…
3c7e22d 
…cale
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - Disabling dotreporter for unit tests
95d942c
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - Reworked the server superglobal for the request
9a8b62e
niden added a commit that referenced this issue Jun 30, 2019
@niden
[#14212] - Updated the changelog
9f4fe86
@niden
Copy link
Sponsor Member Author

niden commented Jun 30, 2019

Addressed in #14223

@niden niden closed this as completed Jun 30, 2019
4.0.0 Release automation moved this from In progress to Done Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SidRoberts SidRoberts

Labels
enhancement Enhancement to the framework
Projects
No open projects
4.0.0 Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@niden @SidRoberts @scrnjakovic @CameronHall