Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Improve stubs generation #15343

Closed
Jeckerson opened this issue Mar 26, 2021 · 2 comments · Fixed by #15362
Closed

[BUG]: Improve stubs generation #15343

Jeckerson opened this issue Mar 26, 2021 · 2 comments · Fixed by #15362
Assignees
@Jeckerson
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report enhancement Enhancement to the framework
Projects
Phalcon Roadmap

Comments

@Jeckerson
Copy link
Member

  1. Generate stubs
  2. Pick static code analyzers
  3. Run them against generated stubs
  4. Fix Phalcon's code in Zephir
@Jeckerson Jeckerson added enhancement Enhancement to the framework bug A bug report 5.0 The issues we want to solve in the 5.0 release labels Mar 26, 2021
@Jeckerson Jeckerson self-assigned this Mar 26, 2021
@niden niden added this to Active Sprint Tasks in Phalcon Roadmap Mar 28, 2021
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Add vimeo/psalm package
329d1fa
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Bump ZEPHIR_VERSION
63e0246
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Add stubs generation and validation
2059906
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Add Zephir install step
299d764
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Add missing installation step
800ef57
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Remove limitation of branches
0d98eaa
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
Merge branch '5.0.x' into #15343-improve-stubs
fac9bf8 
# Conflicts:
#	.github/workflows/build-and-test.yml
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Move stubs validation into static-code-analysis.yml workflow
70eaea3
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Add 'Setup PHP' step
eb5a696
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Add 'Install Packages' step
9b27c92
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Add '--ignore-platform-reqs' flag
bcf696c
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Update CHANGELOG-5.0.md
27a3889
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Mass phpdoc fix
414c597
Jeckerson added a commit that referenced this issue Apr 2, 2021
@Jeckerson
#15343 - Mass phpdoc fix
f460dd3
Jeckerson added a commit that referenced this issue Apr 10, 2021
@Jeckerson
#15343 - Improve condition
c6a0cfd
Jeckerson added a commit that referenced this issue Apr 10, 2021
@Jeckerson
#15343 - Improve condition
cd13a13
Jeckerson added a commit that referenced this issue Apr 10, 2021
@Jeckerson
Merge branch '5.0.x' into #15343-improve-stubs
40758e7
Jeckerson added a commit that referenced this issue Apr 10, 2021
@Jeckerson
#15343 - Improve stubs
a58ca6f
Jeckerson added a commit that referenced this issue Apr 30, 2021
@Jeckerson
#15343 - Improve stubs
a4745fa
Jeckerson added a commit that referenced this issue Apr 30, 2021
@Jeckerson
#15343 - Improve stubs + types fixes
6154400
Jeckerson added a commit that referenced this issue Apr 30, 2021
@Jeckerson
Merge branch '5.0.x' into #15343-improve-stubs
fbf3f2c
Jeckerson added a commit that referenced this issue May 1, 2021
@Jeckerson
Merge branch '5.0.x' into #15343-improve-stubs
5bddc28
Jeckerson added a commit that referenced this issue May 1, 2021
@Jeckerson
#15343 - Refactor Support/Debug properties
f866382
Jeckerson added a commit that referenced this issue May 1, 2021
@Jeckerson
#15343 - Fix level 8 errors
c2e3d4d
Jeckerson added a commit that referenced this issue May 2, 2021
@Jeckerson
#15343 - Fix level 6 errors
fd5a614
Jeckerson added a commit that referenced this issue May 2, 2021
@Jeckerson
#15343 - Fix level 5 errors
60af4ae
Jeckerson added a commit that referenced this issue May 2, 2021
@Jeckerson
#15343 - Revert default property values in Phalcon\Tag
f55434d
@Jeckerson Jeckerson linked a pull request May 2, 2021 that will close this issue
#15343 - Improve stubs #15362
Merged
5 tasks
@Jeckerson
Copy link
Member Author

Below psalm errorLevel 5 is blocked by zephir-lang/zephir#2239

Jeckerson added a commit that referenced this issue May 2, 2021
@Jeckerson
#15343 - Fix typo
9dbb78a
niden added a commit that referenced this issue May 3, 2021
@niden
Merge pull request #15362 from phalcon/#15343-improve-stubs
874a872 
#15343 - Improve stubs
@niden niden moved this from Active Sprint Tasks to Working on it in Phalcon Roadmap May 3, 2021
@niden
Copy link
Sponsor Member

niden commented May 3, 2021

Resolved in #15362

@niden niden closed this as completed May 3, 2021
Phalcon Roadmap automation moved this from Working on it to Implemented May 3, 2021
@niden niden moved this from Implemented to Released in Phalcon Roadmap Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report enhancement Enhancement to the framework
Projects
Phalcon v5
Archived in project
Phalcon Roadmap
  
Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#15343 - Improve stubs phalcon/cphalcon
2 participants
@niden @Jeckerson