Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Change exists to has #15785

Closed
niden opened this issue Nov 14, 2021 · 1 comment · Fixed by #15793
Closed

[NFR]: Change exists to has #15785

niden opened this issue Nov 14, 2021 · 1 comment · Fixed by #15793
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Phalcon Roadmap

Comments

@niden
Copy link
Sponsor Member

niden commented Nov 14, 2021

A number of components use has to check existence of an element in a collection and others use exists.

To have everything uniformed, we need to change exists to has. The exists will be deprecated and removed in future versions of Phalcon
@niden niden added the new feature request Planned Feature or New Feature Request label Nov 14, 2021
@niden niden self-assigned this Nov 14, 2021
@niden niden added the 5.0 The issues we want to solve in the 5.0 release label Nov 14, 2021
@niden niden added this to Active Sprint Tasks in Phalcon Roadmap Nov 14, 2021
@niden niden moved this from Active Sprint Tasks to Working on it in Phalcon Roadmap Nov 16, 2021
@niden niden mentioned this issue Nov 17, 2021
Merged
5 tasks
@niden niden linked a pull request Nov 17, 2021 that will close this issue
T15785 change exists to has #15793
Merged
5 tasks
@niden
Copy link
Sponsor Member Author

niden commented Nov 17, 2021

Resolved in #15793

@niden niden closed this as completed Nov 17, 2021
Phalcon Roadmap automation moved this from Working on it to Implemented Nov 17, 2021
niden added a commit to niden/phalcon that referenced this issue Nov 18, 2021
@niden
refactor: changed exists to has in various components
e63ee9d 
alignment with cphalcon phalcon/cphalcon#15785

Refs phalcon#6.0.x
@niden niden mentioned this issue Nov 18, 2021
Merged
niden added a commit to niden/phalcon that referenced this issue Nov 18, 2021
@niden
refactor: changed exists to has in various components
4fd7d54 
alignment with cphalcon phalcon/cphalcon#15785

Refs phalcon#6.0.x
niden added a commit to phalcon/phalcon that referenced this issue Nov 18, 2021
@niden
refactor: changed exists to has in various components
85498c8 
alignment with cphalcon phalcon/cphalcon#15785

Refs #6.0.x
@niden niden moved this from Implemented to Released in Phalcon Roadmap Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Phalcon Roadmap
  
Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15785 change exists to has
1 participant
@niden