Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Refactor Logger\Adapter\Stream - non locking write #16072

Closed
niden opened this issue Aug 24, 2022 · 1 comment · Fixed by #16073
Closed

[NFR]: Refactor Logger\Adapter\Stream - non locking write #16072

niden opened this issue Aug 24, 2022 · 1 comment · Fixed by #16073
Assignees
@niden
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Phalcon Roadmap

Comments

@niden
Copy link
Sponsor Member

niden commented Aug 24, 2022

Phalcon\Logger\Adapter\Stream needs to be refactored so as not to have any locking writes and close the pointer as soon as possible.
@niden niden added the new feature request Planned Feature or New Feature Request label Aug 24, 2022
@niden niden self-assigned this Aug 24, 2022
@niden niden added the 5.0 The issues we want to solve in the 5.0 release label Aug 24, 2022
@niden niden added this to Working on it in Phalcon Roadmap Aug 24, 2022
niden added a commit to niden/cphalcon that referenced this issue Aug 24, 2022
@niden
[phalcon#16072] - refactored process() to open, check for locks, writ…
60054b1 
…e, close stream
niden added a commit to niden/cphalcon that referenced this issue Aug 24, 2022
@niden
[phalcon#16072] - updating changelog
5c032b9
@niden niden mentioned this issue Aug 24, 2022
Merged
5 tasks
@niden niden linked a pull request Aug 24, 2022 that will close this issue
T16072 logger stream no lock #16073
Merged
5 tasks
niden added a commit to niden/cphalcon that referenced this issue Aug 25, 2022
@niden
[phalcon#16072] - forcing EX lock
68f2acb
@niden
Copy link
Sponsor Member Author

niden commented Aug 25, 2022

Resolved in #16073

@niden niden closed this as completed Aug 25, 2022
Phalcon Roadmap automation moved this from Working on it to Implemented Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Phalcon Roadmap
  
Implemented
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T16072 logger stream no lock niden/cphalcon
1 participant
@niden