Bugfix #10912 (Micro Middleware (before) does not stop operation)

[pauliuspetronis]

In this pull request is one important change.

before this change:

1. if event (before) is closure and return false - cancels the route execution
2. if event (before) is MiddlewareInterface object and return false/true/... - not cancels route execution

In this change:

1. if event (before) is closure and return false/true/... - not cancels route execution
2. if event (before) is MiddlewareInterface and return false/true/... - not cancels route execution

If you need to cancel execution on event (before) - in both cases must be called $microApplication->stop();

For example:

<?php
$app = new Phalcon\Mvc\Micro();
$app->before(function () use ($app) {
    if ($app['session']->get('auth') == false) {
        $app->stop();
        return false;
    }
    return true;
});
$app->handle();

or

<?php
class Auth implements Phalcon\Mvc\Micro\MiddlewareInterface
{
    public function call(Phalcon\Mvc\Micro $app)
    {
         if ($app['session']->get('auth') == false) {
            $app->stop();
            return false;
        }
        return true;
    }
}
$app = new Phalcon\Mvc\Micro();
$app->before(new Access());
$app->handle();

[andresgutierrez]

I think this must be submitted to 2.1.x

[sszdh]

So what is return false/true for, anymore?

Why we should use $app->stop()

Thanks

[pauliuspetronis]

@andresgutierrez - submitted (#10931)

[JuliusKoronci]

This is still there even with version 3+ ..no matter if your return true, false or call $app->stop() it will not top with the MiddlewareInterface